[iOS][Android][face-detector][ads-admob][firebase-core][firebase-analytics] Upgrade native libraries #12125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarthec
requested review from
EvanBacon,
IjzerenHein and
tsapeta
as code owners
bbarthec
requested review from
ccheever,
cruzach and
brentvatne
and removed request for
IjzerenHein,
EvanBacon and
ccheever
bbarthec
force-pushed
the
@bbarthec/face-detector/ios/upgrade-firebase-to-google-ml-kit
branch
from
7c81b62
to
8f9571f
Compare
brentvatne
force-pushed
the
@bbarthec/face-detector/ios/upgrade-firebase-to-google-ml-kit
branch
from
8f9571f
to
b73c4b2
Compare
|
@bbarthec - looks like we need to update changelog for ci to pass here |
…coapods] Upgrade native libraries & temporarily ignore verioned ABIs - upgrade firebase_sdk_version to 7.7.0 - upgrade Google-Mobile-Ads-SDK to 7.69.0 - migrate from Firebase/MLVision to GoogleMLKit/FaceDetection
- fixed warning for ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES - removed ABI38_0_0 yoga reference from OTHER_SWIFT_FLAGS
- update module code by replacing Firebase references with GoogleMLKit ones
…vent names - updated com.google.android.gms:play-services-ads from 17.x.x to 19.4.0 - updated event names to resemble new RewardedAd lifecycle - updated docs for RewardedAd
bbarthec
force-pushed
the
@bbarthec/face-detector/ios/upgrade-firebase-to-google-ml-kit
branch
from
b73c4b2
to
09b80d8
Compare
bbarthec
changed the title
brentvatne
approved these changes
Mar 8, 2021
brentvatne
deleted the
@bbarthec/face-detector/ios/upgrade-firebase-to-google-ml-kit
branch
|
@bbarthec , Thanks for upgrading AdMob SDK for expo. Do we need to change anything else do make it work? I changed the event names but still get -- using expo 41 |
|
@cristian-milea you shouldn't need to make any other changes. That error comes from Admob itself, so you should search for that error message in their documentation and see what causes they point to. I have seen that error when the ad unit ID is just too new (it takes some time) |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We have to upgrade
ads-admob, because of new Google's polices (more info here) and this upgrade triggers other cocoapods dependencies updates.Major update refers to
expo-face-detector, because it has to be upgraded from oldFirebase/MLVisionlibrary to newGoogleMLKit/FaceDetectionlibrary.supersedes #12126
closes https://linear.app/expo/issue/ENG-177/upgrade-google-admob
closes #11941
closes #11934
How
iOS
Upgrades native libraries:
firebase_sdk_versionfrom6.14.0to7.7.0infirebase-*modules - followed changelog and nothing important for us changedGoogle-Mobile-Ads-SDKfrom7.55.1to7.69.0inads-admobmodule - nothing important changed according to changelogFirebase/MLVisiontoGoogleMLKit/FaceDetection@2.1.0inface-detectormodule - followed migration plan & changesRefrained from upgrading
Google-Mobile-Ads-SDKto the newest version8.1.0as it seems too big for this PR.Had to backport library upgrades to older SDKs as of cocoapods not accepting multiple versions of single library.
Android
To achieve
ads-admobparity on both platform and because of https://developers.google.com/admob/android/rel-notes#19.3.0 (Android 11 is supported since19.4.0) I had to update Android native dependency as well. I has to upgrade this library code to achieve feature parity on both platforms.Additionally I've adjusted event names emitted by this module (now these are much more simplified compared with the previous ones).
Test Plan
Expo GOand launched bothnclandtest-suitewithUNVERSIONEDSDK and checked affected modules - every screen/test works.bare-expo, but the problem seems to live inFlipper-related code, so it's out of scope of this PR and has to be fixed separately after this PR lands.