[asset][expo] Add manifest check in expo and expo-asset to avoid yellowbox on bare workflow apps

[mogery]

Why

As stated in issue #11888, expo-asset (and additionally, expo's logging.fx.ts) accessed Constants.manifest on bare workflow apps without proper existance checks beforehand. This resulted in annoying yellowbox warnings in bare workflow debug builds.

Therefore, this PR fixes #11888.

How

I changed expo-assets -> PlatformUtils.getManifest to use IS_MANAGED_ENV and IS_BARE_ENV_WITH_UPDATES to determine available sources for the manifest. If IS_MANAGED_ENV is true, it will use Constants.manifest, if IS_BARE_ENV_WITH_UPDATES is true, it will use Updates.manifest, else it will just return {}. A similar method is used in expo -> environment/logging.fx.

This added expo-updates as a dependency to expo and expo-asset.

(I also had to change expo-asset -> AssetSources-test._mockConstants to set appOwnership, since that is how IS_MANAGED_ENV is determined.)

Test Plan

• Ran yarn test on expo and expo-assets
• Copied updated modules/builds to a bare app to confirm fix

I did not write any extra tests for this, since I don't think it's needed.

[mogery]

I can't find how to fix this symlink error for the life of me. Can someone help?

[mogery]

Nevermind, this should fix it.

[mogery]

Is Danger's GitHub token broken? Seems to always fail.

[esamelson]

Thank you very much for the PR @mogery ! Many apologies that we already happened to be working on this issue at the same time, otherwise we'd gladly work with you to review and accept your PR.

In this case, we're choosing the solution in #12237 instead, for a couple of reasons -- (1) despite your comment on that PR, it does actually fall back to Updates.manifest, by utilizing the logic that already exists in Constants.ts; we'd prefer to expose an internal-facing property on Constants rather than maintain two separate copies of the same logic for finding the manifest, and (2) unfortunately adding expo-updates as a dependency to other packages comes with side effects that we don't want, so we try to avoid this whenever possible.

However, we really appreciate the time and effort you put into this PR -- I know it's not so easy to even get the repo set up currently! -- and look forward to other fixes/contributions from you in the future.

[mogery]

Ooooh, sorry, I wasn't aware that Constants had that behaviour already. No problem, my apologies.