[constants][asset] Suppress warning upon no manifest available #12237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarthec
force-pushed
the
@bbarthec/constants/asset/suppress-warning-upon-no-manifest
branch
from
f396764
to
3e3b1e9
Compare
bbarthec
requested review from
esamelson and
brentvatne
and removed request for
ide and
tsapeta
bbarthec
force-pushed
the
@bbarthec/constants/asset/suppress-warning-upon-no-manifest
branch
from
3e3b1e9
to
5afffd5
Compare
Deliver new `Constants.__unsefaNoWarnManifest` property that behaves exaclty the same as `Constants.manifest`, but prevent the warning about nullish manifest from being printed. When in bare workflow a user might encounter scenario when there's no manifest available. `expo-asset` tries to read manifest anyway and it triggers the warning, even though `expo-asset` can manage without `Constants.manifest`. This change fixes that scenario and turns off this no-op warning.
bbarthec
force-pushed
the
@bbarthec/constants/asset/suppress-warning-upon-no-manifest
branch
from
5afffd5
to
e940205
Compare
brentvatne
deleted the
@bbarthec/constants/asset/suppress-warning-upon-no-manifest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolves https://linear.app/expo/issue/ENG-576/make-expo-asset-not-warn-about-missing-manifest
Resolves #11888
Supersedes #12230
When in bare workflow a user might encounter scenario when there's no
manifest available.
expo-assettries to read manifest anyway and it triggers the warning,even though
expo-assetcan manage withoutConstants.manifest.This change fixes that scenario and turns off this no-op warning.
How
Constants.__unsefaNoWarnManifestproperty that behaves exactly the sameas
Constants.manifest, but prevent the warning about nullish manifest from being printed.expo-assetand inlogging.fxinexpopackage.Test Plan
Copied the changes to the
bare workflowproject having this problem and ensured the warning is no longer there 😉