Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] Upgrade react-native-maps to 0.28.0 #13158

Closed
wants to merge 1 commit into from

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Jun 4, 2021

Why

SDK 42

How

et update-module -m react-native-maps

Test Plan

There aren't a lot of new features, this is the changelog:


0.28.0

  • Common: #3705 Update example project
  • Common: #3424 Bugfix for the "require cycles" warning
  • Common: #3452 Ability to pass a Marker image as Geojson prop
  • Common: #3516 Polyline props to obtain dashed/dotted lines in Geojson component
  • Common: #3358 onRegionChange sends a boolean indicating if the move was from the user (true) or an animation (false)
  • Common: #3658 Geojson stroke color, stroke width, fill color, and marker color properties preserved
  • Common: #3695 AnimateCamera duration bugfixed
  • iOS: #3383 Added tintColor prop for setting the color of the map
  • Android: #3414 Play services version updated

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.io and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@byCedric byCedric requested review from ide and tsapeta as code owners June 4, 2021 12:03
@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jun 4, 2021
@byCedric
Copy link
Member Author

byCedric commented Jun 4, 2021

The iOS erros is a Pods issue with Lottie, I guess we have to wait until that's resolved?

@tsapeta
Copy link
Member

tsapeta commented Jun 4, 2021

@byCedric Looks like you updated react-native submodule — if you bring it back to exp-latest branch then the CI jobs should pass 😉

@byCedric
Copy link
Member Author

byCedric commented Jun 4, 2021

Hmm, not sure what I did that updated it. I only ran the command in the PR. Let me retry it 😬

@byCedric byCedric closed this Jun 7, 2021
@tsapeta tsapeta deleted the @bycedric/react-native-maps/update branch June 7, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants