Pass camera move's reason to JS callbacks

[yairopro]

Does any other open PR do the same thing?

There is a PR that solves likely the problem #2935, but with a workaround.
The problem we are trying to solve is to know the reason when the region has changed on the map.
Using onPanDrag, implemented by the PR #2935, is a non stable workaround. Because will would have to first store somewhere a boolean on the onPanDrag, and use it once onRegionChangeComplete.

What issue is this PR fixing?

Issue #1620 and #2756.

How did you test this PR?

I implemented and tested (on a real device) the code for android. The iOS part too has been implemented by my friend. And was tested on an emulator.

[yairopro]

To pass the enum value to the JS callbacks onRegionChange & onRegionChangeComplete, I first added the property reason to the android RegionChangeEvent. And once the event received on the JS thread, I pass a 2nd object parameter, called details, to the callback, like onRegionChange(region, details). I build the details object before calling the callback.
For now, details has only one property reason. In the future it may have other properties, which like reason won't have their place in the Region object.

[yairopro]

Since on iOS the map gives only a boolean, if it's a user gesture or not, then I adapted the same behaviour for android (it converts the integer to the same boolean) and renamed the property from reason to isGesture.

[rborn]

LGTM @christopherdro 🐽

@yairopro 😻

[rborn]

@yairopro I know this is a very old PR 😅 but could you add the extra info in the docs too (the events seem to be missing the details param ?
Then I'll merge 🙂

[yairopro]

Oh you're right. I've forgotten the documentation.
Let me some time to re-read the PR code.

[yairopro]

@rborn I updated the documentation.
You can edit it too if you wish.

[rborn]

😻

[yairopro]

🥳 Thanks

[rennehir]

Nice feature, this would really help us a lot with our product!

But I noticed that there hasn't been a release since March. @rborn @yairopro do you have any estimates when that might occur? Or should I just point my package.json to a specific commit?

Cheers, great work! 🥳

[yairopro]

Hi @rennehir
I can't say, I am just an outside contributor.

[juice49]

This doesn't seem to be working with Apple Maps on iOS. I logged the nativeEvent variable in _onChange, and the isGesture property is missing:

{
  "region": {
    "longitude": -2.7246242753611227,
    "latitude": 54.88447300842492,
    "latitudeDelta": 4.24778519660066,
    "longitudeDelta": 4.548340505366269
  },
  "target": 989,
  "continuous": true
}

I get the property as expected on Android, for example:

{
  "region": {
    "longitudeDelta": 4.520089812576771,
    "longitude": -2.9489495046436787,
    "latitudeDelta": 3.685225103923095,
    "latitude": 55.22018295561497
  },
  "isGesture": true,
  "continuous": true
}

I haven't tested this with Google Maps on iOS.

[yairopro]

Hi @juice49
The flag comes only with google map (iOS too).
I should have say that in the doc, my bad.

[juice49]

Thanks @yairopro! I wasn't sure if this should work or not.

[rborn]

@juice49 mind a PR with the doc change ? 😍

[juice49]

@rborn Absolutely! PRd in #3589. Thank you for your work maintaining this excellent library 🙂.

[rborn]

@juice49 merged 😻

[juice49]

Thanks @rborn!

[RyanTG]

Sorry - earlier today I commented on the commit rather than the issue. I thus deleted the comment, and here it is in a more appropriate place:

Just in case the developers of this commit missed it, some of us are not able to get this to work in version 0.28.0. isGesture is undefined. Any guidance?
#3818

[christopherdro]

Looking through the source it appears the isGesture property is only available on google maps. If you are using Apple Maps then the value will be undefined.

[RyanTG]

We are using Google Maps on both iOS and Android, and version 0.28.0. It's unclear if we're doing something wrong (and it's working for others) or if there is an issue with the feature.

[RyanTG]

@yairopro I just want to say thanks for the isGesture feature. Looking back at the issues on this repo, it's been brought up at least half a dozen times over the past few years - so it clearly solves a much-needed issue! It works great, and it saved our butts.

It would be cool to have this functionality on Apple Maps, too. Is there any chance of that? In our particular use case, now that an upcoming version of react-native-maps is going to include a manual theme toggle for Apple Maps, there is feature parity between the two (aside from isGesture).

[yairopro]

Hi @RyanTG
😁 I'm really happy to hear that my work helps. And I really thank you for this warming message.

But unfortunately, I am not able to help you since I am not an iOS developer. sorry
The iOS code in this PR has been added by my colleague who I asked to help me once for this PR but he's not used to open-source development. I just gave him instructions how to implement the feature in objective-c after I've written it on the other side for Android in java, and the data-flow was the same.