[notifications] Add permission hooks from modules factory #13863
Conversation
packages/expo-notifications/src/NotificationPermissionsModule.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13863 (review)
expo-bot
added
bot: suggestions
byCedric
force-pushed
the
@bycedric/permissionhook/expo-notifications
branch
from
270e401
to
6fb90f3
Compare
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13863 (review)
byCedric
force-pushed
the
@bycedric/permissionhook/expo-notifications
branch
from
6fb90f3
to
7ce2518
Compare
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13863 (review)
byCedric
force-pushed
the
@bycedric/permissionhook/expo-notifications
branch
2 times, most recently
from
ec81908
to
1f674d3
Compare
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13863 (review)
byCedric
force-pushed
the
@bycedric/permissionhook/expo-notifications
branch
from
1f674d3
to
f9254a3
Compare
There was a problem hiding this comment.
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.
I've found some issues in your pull request that should be addressed (click on them to expand) 👇
⚠️ Suggestions: Missing changelog entries
Your changes should be noted in the changelog. Read Updating Changelogs guide and consider (it's optional) adding an appropriate entry to the following changelogs:
Generated by ExpoBot 🤖 against f9254a3
byCedric
force-pushed
the
@bycedric/permissionhook/expo-notifications
branch
from
f9254a3
to
ff8dbff
Compare
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
* [notifications] Add permission hooks from modules factory * [notifications] Add changelog entry * [modules-core] Add generic options to permission hook * [notifications] Use proper permission requesters with options * [notifications] Add the changelog line breaks back
Blocked by #13860Why
Adds a permission hook from #13782 to
expo-notifications.How
Exported permission hook and permission hook options type.
Test Plan
See example in docblock.
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).