[dev-menu][android] Fix Only fullscreen opaque activities can request orientation
#14066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-1795 Unable to target Android 8
Developers are unable tp build for Android 8 because of our device orientation logic |
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
esamelson
approved these changes
Aug 16, 2021
|
lukmccall
deleted the
@lukmccall/dev-menu/fix-only-opaque-activiries-can-request-orientation
branch
esamelson
pushed a commit
that referenced
this pull request
Sep 2, 2021
…t orientation` (#14066) # Why Fixes #13965. Closes ENG-1795. # How Due to an issue with API 26, we can't request orientation when the activity is translucent. Unfortunately, this isn't an ideal solution, cause on API 26 users may open the dev-menu in landscape orientation. There may be some visual bugs. So in the future, we may want to add support for landscape orientation. For now, I removed crashes. # Test Plan - new project with dev-menu ✅
FelipeACP
pushed a commit
to FelipeACP/expo
that referenced
this pull request
Sep 18, 2021
…t orientation` (expo#14066) # Why Fixes expo#13965. Closes ENG-1795. # How Due to an issue with API 26, we can't request orientation when the activity is translucent. Unfortunately, this isn't an ideal solution, cause on API 26 users may open the dev-menu in landscape orientation. There may be some visual bugs. So in the future, we may want to add support for landscape orientation. For now, I removed crashes. # Test Plan - new project with dev-menu ✅
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #13965.
Closes ENG-1795.
How
Due to an issue with API 26, we can't request orientation when the activity is translucent. Unfortunately, this isn't an ideal solution, cause on API 26 users may open the dev-menu in landscape orientation. There may be some visual bugs. So in the future, we may want to add support for landscape orientation. For now, I removed crashes.
Test Plan