[dev-client] support landscape orientation #18509
Conversation
ENG-1804 Support landspace orientation in Dev Menu
A follow up to #14066 Due to an issue with API 26, we can't request orientation when the activity is translucent. Unfortunately, this isn't an ideal solution, cause on API 26 users may open the dev-menu in landscape orientation. There may be some visual bugs. So in the future, we may want to add support for landscape orientation. |
| window.rootViewController = self.reactDelegate?.createRootViewController() | ||
| window.rootViewController!.view = rootView | ||
|
|
||
| // NOTE: this order of assignment seems to actually have an effect on behaviour |
There was a problem hiding this comment.
@keith-kurak this appears to have been the root issue - pretty underwhelming!
There was a problem hiding this comment.
WOW, I could have looked at that for years, what a find!
There was a problem hiding this comment.
Nice work!
I confirmed this also resolves #15835 (the bug that originally got me interested in this :-) ).
| [[UIDevice currentDevice] setValue:@(orientation) forKey:@"orientation"]; | ||
| [UIViewController attemptRotationToDeviceOrientation]; |
There was a problem hiding this comment.
i'm curious about why this is no longer needed -- with this gone, what sets the orientation when it is supposed to be restricted?
There was a problem hiding this comment.
I could be wrong but I believe this is set at the Info.plist / OS level. I'll double check but i'm pretty sure these lines don't do anything
There was a problem hiding this comment.
(those plist values are set during prebuild / config plugin step)
There was a problem hiding this comment.
Ahh, I see, that makes sense. I do think there's some value from having a dev client (specifically) be able to respond dynamically to changing app.json values -- like, it would be nice if you could modify this app.json value and then see the effect right away in your dev client instead of having to make a new build. But if that is much trickier now then it probably isn't a huge deal for this particular field.
There was a problem hiding this comment.
I'll see if the app.json modifications work w/o rebuild - if so i don't see any harm in including it
There was a problem hiding this comment.
seems like this only works on initial launch (i.e it will rotate to the configured orientation on launch) but the orientation is not locked unless its set in the build settings. it makes more sense to me to omit these lines
|
Is there anything we can do to help this get released? |
| @@ -51,7 +51,7 @@ class DevMenuHost(application: Application) : ReactNativeHost(application) { | |||
| return packages | |||
| } | |||
|
|
|||
| override fun getUseDeveloperSupport() = false // change it and run `yarn start` in `expo-dev-menu` to launch dev menu from local packager | |||
| override fun getUseDeveloperSupport() = true // change it and run `yarn start` in `expo-dev-menu` to launch dev menu from local packager | |||
expo-bot
added
bot: passed checks
ajsmth
deleted the
andrew/eng-1804-support-landspace-orientation-in-dev
branch
Why
Closes ENG-1804
this took a bit longer than anticipated as I ran into some orientation related bugs:
Simulator.Screen.Recording.-.iPhone.12.-.2022-08-04.at.10.31.50.mp4
How
Removed the restriction for portrait orientation on the native view controllers in the dev menu, then updated the styles of the dev menu to look decent in landscape. I had to adjust some of the calculations done by the bottom sheet to get the right snap point values, but I think it works fairly well
The big issue was related to the video posted above (on iOS only) - this was solved by "properly" setting the root view controllers' view in DevLaunchers delegate subscriber. It seems like a small change but seemed to do the trick. 🤷♀️
Test Plan
I tested both platforms with and without
expo-screen-orientationinstalled - updating theapp.jsonorientation value to bedefaultlandscapeandportraitand ensured that behaviour was as expected: locked to the values when landscape / portrait, but rotates when defaultHere is a quick video demonstrating:
Simulator.Screen.Recording.-.iPhone.12.-.2022-08-04.at.14.22.00.mp4
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).