Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modules-core] Fix compatibility with RN 0.65 (view manager installation) #14348

Merged
merged 3 commits into from
Sep 10, 2021

Conversation

lukmccall
Copy link
Contributor

Why

Fixes the new installation method of view managers that doesn't compile with RN 0.65.

How

In the newest RN, the Facebook team changed the signature of the RCTComponentData constructor.

Test Plan

  • simple app with RN 0.65
import React from "react";
import { StyleSheet, Text, View } from "react-native";
import { LinearGradient } from "expo-linear-gradient";

export default function App() {
  return (
    <View style={styles.container} testID="LocalAppMainScreen">
      <LinearGradient
        // Background Linear Gradient
        colors={["rgba(0,0,0,0.8)", "transparent"]}
        style={styles.background}
      />
      <Text>Open up App.js to start working on your app!</Text>
    </View>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: "#fff",
    alignItems: "center",
    justifyContent: "center",
  },
  background: {
    position: "absolute",
    left: 0,
    right: 0,
    top: 0,
    height: 300,
  },
});

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 8, 2021
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@swmansion.com>
@expo-bot
Copy link
Collaborator

expo-bot commented Sep 9, 2021

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider (it's optional) adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against f89e17d

@lukmccall lukmccall merged commit c1afd7a into master Sep 10, 2021
@lukmccall lukmccall deleted the @lukmccall/modules-core/fix-comptibility-with-rn-65 branch September 10, 2021 10:31
FelipeACP pushed a commit to FelipeACP/expo that referenced this pull request Sep 18, 2021
…ion) (expo#14348)

# Why

Fixes the new installation method of view managers that doesn't compile with RN 0.65.

# How

In the newest RN, the Facebook team changed the signature of the `RCTComponentData` constructor. 

# Test Plan

- simple app with RN 0.65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants