-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo-updates] bump @expo/config-plugins to 4.0.2 #14788
Conversation
f2cdca3
to
bd7c722
Compare
10e76a9
to
d1ae8d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, would just be good to double check that nothing unexpected broke here in the major version bump (what were the breaking changes?)
These were the changes since
|
Refs #14689 (comment) #14561 It would be nice to update the config for all the packages in workspace, but I can understand if it out of the scope of this PR. 🙂 |
I'm hoping to cherry pick this to sdk-43 before it goes out 🤞 so want to keep this a lean as possible |
Why
Support runtime version policies in the expo-updates plugin by bumping the @expo/config-plugin to 4.0.2
How
We are only importing from config plugins in the one place where we import the expo-updates plugin: https://github.com/expo/expo/blob/master/packages/expo-updates/plugin/src/withUpdates.ts#L2
Looked through the changelog to make sure there were no unexpected changes to the plugin: https://github.com/expo/expo-cli/blob/master/CHANGELOG.md
Test Plan
confirmed that policy runtime versions were applied by running expo prebuild in sample repos.
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).