Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-updates] bump @expo/config-plugins to 4.0.2 #14788

Merged
merged 4 commits into from
Oct 18, 2021

Conversation

jkhales
Copy link
Contributor

@jkhales jkhales commented Oct 18, 2021

Why

Support runtime version policies in the expo-updates plugin by bumping the @expo/config-plugin to 4.0.2

How

We are only importing from config plugins in the one place where we import the expo-updates plugin: https://github.com/expo/expo/blob/master/packages/expo-updates/plugin/src/withUpdates.ts#L2

Looked through the changelog to make sure there were no unexpected changes to the plugin: https://github.com/expo/expo-cli/blob/master/CHANGELOG.md

Test Plan

confirmed that policy runtime versions were applied by running expo prebuild in sample repos.

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 18, 2021
@jkhales jkhales force-pushed the @jkhales/bump-config-plugins branch from f2cdca3 to bd7c722 Compare October 18, 2021 17:24
@jkhales jkhales force-pushed the @jkhales/bump-config-plugins branch from 10e76a9 to d1ae8d8 Compare October 18, 2021 17:37
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 18, 2021
Copy link
Contributor

@esamelson esamelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, would just be good to double check that nothing unexpected broke here in the major version bump (what were the breaking changes?)

@jkhales
Copy link
Contributor Author

jkhales commented Oct 18, 2021

looks good, would just be good to double check that nothing unexpected broke here in the major version bump (what were the breaking changes?)

These were the changes since 3.1.0. The only thing that gives any concern about breaking the withUpdates plugin is the last one. But confirmed everything works OK on a demo repo.

  • expo/expo-cli@27d90af
  • [config-plugins][expo-cli][xdl] Fix runtimeVersion related code to build against config-types. 909d47
  • [config-plugins] Add hermes support for ios Podfile.properties.json (#3796)
  • [config-plugins] Escape single quotes in project name (#3838)
  • [config-plugins] extend base mods (#3852)
  • [config-plugins] Use upstream react-native/normalize-color (#3826)
  • [config-plugins] dodge extraneous Info.plist warning in managed projects (#3835)

@Simek
Copy link
Collaborator

Simek commented Oct 18, 2021

Refs #14689 (comment) #14561

It would be nice to update the config for all the packages in workspace, but I can understand if it out of the scope of this PR. 🙂

@jkhales
Copy link
Contributor Author

jkhales commented Oct 18, 2021

Refs #14689 (comment) #14561

It would be nice to update the config for all the packages in workspace, but I can understand if it out of the scope of this PR. 🙂

I'm hoping to cherry pick this to sdk-43 before it goes out 🤞 so want to keep this a lean as possible

@jkhales jkhales merged commit 5b42d92 into master Oct 18, 2021
@jkhales jkhales deleted the @jkhales/bump-config-plugins branch October 18, 2021 20:22
@jkhales jkhales mentioned this pull request Oct 19, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants