-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[autolinking] Patch react podspec for swift integration #15299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
reviewed
Nov 25, 2021
3 tasks
tsapeta
approved these changes
Nov 26, 2021
Kudo
force-pushed
the
@kudo/react-modulemap
branch
from
November 27, 2021 13:45
7efde5b
to
7fe1944
Compare
Kudo
force-pushed
the
@kudo/react-modulemap
branch
from
November 27, 2021 16:17
7fe1944
to
3b939e7
Compare
there was an issue to have a different checksum on CI. the module_map is an absolute path and my path is different to CI. so i've add further patch |
3 tasks
This was referenced Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
there are tons of mixing swift and objc issues in expo-modules-core. e.g.
include of non-modular header inside framework module
when prebuild expo-modules-corethe root cause is that clang doesn't generate submodules correctly. although clang can transform
#import <React/RCTBridge.h>
to@import React.RCTBridge;
, clang cannot do it right as React.RCTBridge submodule doesn't exist. as swift only know modules, this will cause lots of problems when we use react types in swift.How
React-Core.podspec
with custom modulemap for clang to generate submodules correctly. (details in code comment)PodTarget
monkey patch withSandbox
. this new approach can patch podspec on the fly.Test Plan
BUILD_LIBRARY_FOR_DISTRIBUTION
for expo-modules-core pod project and check the swiftinterface for ExpoModulesCore.e.g.
/Users/kudo/Library/Developer/Xcode/DerivedData/BareExpo-brnnteedtepltiasryrqyexlvweu/Build/Products/Debug-iphonesimulator/ExpoModulesCore/ExpoModulesCore.swiftmodule/x86_64-apple-ios-simulator.swiftinterface
before: it's
ExpoModulesCore.RCTViewManager
after: it's
React.RCTViewManager
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).