[random] Fix ios build break on sdk 44 #15626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
brentvatne
approved these changes
Dec 18, 2021
brentvatne
pushed a commit
that referenced
this pull request
Dec 18, 2021
* [random] Fix ios build break on sdk 44 * update changelog
NightScript370
added a commit
to NightScript370/react-native-call-detection
that referenced
this pull request
Sep 13, 2023
See the following: - expo/expo#15626 - birkir/react-native-sfsymbols#22 - LinusU/react-native-get-random-values#33 Root report: - expo/expo#15649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
for #15299, we should strictly import react headers as
#import <React/*.h>.How
remove
#import "RCTBridgeModule.h"Test Plan
expo init sdk44 #select bare
expo install expo-random
patch
node_modules/expo-random/ios/EXRandom/EXRandom.hexpo run:ios
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).