[dev-launcher][Android] Send uncaught exceptions to bundler server #15938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esamelson
suggested changes
Jan 18, 2022
...uncher/android/src/main/java/expo/modules/devlauncher/helpers/DevLauncherOkHttpExtensions.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/expo/modules/devlauncher/launcher/errors/DevLauncherUncaughtExceptionHandler.kt
Outdated
Show resolved
Hide resolved
...xpo-dev-launcher/android/src/main/java/expo/modules/devlauncher/logs/DevLauncherRemoteLog.kt
Outdated
Show resolved
Hide resolved
...xpo-dev-launcher/android/src/main/java/expo/modules/devlauncher/logs/DevLauncherRemoteLog.kt
Show resolved
Hide resolved
esamelson
approved these changes
Jan 20, 2022
| } | ||
|
|
||
| private fun getLogsUrl(): Uri { | ||
| val logsUrlFromManifest = controller.manifest?.getRawJson()?.optString("logUrl") |
There was a problem hiding this comment.
this should really go through one of the getters in expo-manifest instead of using getRawJson (might need to add getLogUrl there if it doesn't already exist) because this will still only work for classic update manifests.
lukmccall
force-pushed
the
@lukmccall/dev-launcher/send-exception-to-bundler
branch
from
c9b640d
to
7660d6d
Compare
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
lukmccall
deleted the
@lukmccall/dev-launcher/send-exception-to-bundler
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Part of ENG-2401.
How
Send uncaught exceptions to the bundler server if possible. Our dev server has its endpoint where we can send logs. So I've just used it.
Test Plan