Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-manifests][expo-dev-launcher] add logUrl getter to manifest classes #16709

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

esamelson
Copy link
Contributor

Why

resolves ENG-4080

How

Added logUrl getters to base manifest classes on both platforms, replaced usages from #15964 and #15938.

Test Plan

Made a build on each platform, and opened app using expo start --dev-client and expo start --dev-client --force-manifest-type=expo-updates, logged the new logUrl property on manifest to ensure it was nonnull and correct.

Was not able to verify that the actual logging functionality of the dev client still works; I tried to follow the test plans from #15964 and #15938 but did not figure out the right place to throw an exception (it either showed me a redbox or just showed the error as an alert in the dev launcher UI) to trigger the logging. I can try this out again if you could provide more details about how to test this!

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@linear
Copy link

linear bot commented Mar 21, 2022

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 21, 2022
@esamelson esamelson requested a review from ajsmth March 22, 2022 16:40
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 24, 2022
@esamelson esamelson merged commit 65274b0 into main Mar 24, 2022
@esamelson esamelson deleted the @eric/eng-4080 branch March 24, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants