[expo-manifests][expo-dev-launcher] add logUrl getter to manifest classes #16709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
resolves ENG-4080
How
Added
logUrl
getters to base manifest classes on both platforms, replaced usages from #15964 and #15938.Test Plan
Made a build on each platform, and opened app using
expo start --dev-client
andexpo start --dev-client --force-manifest-type=expo-updates
, logged the newlogUrl
property on manifest to ensure it was nonnull and correct.Was not able to verify that the actual logging functionality of the dev client still works; I tried to follow the test plans from #15964 and #15938 but did not figure out the right place to throw an exception (it either showed me a redbox or just showed the error as an alert in the dev launcher UI) to trigger the logging. I can try this out again if you could provide more details about how to test this!
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).