-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[av] audio: refactor interruption modes to enums, export missing type #16145
Conversation
[ncl] fix and improve Audio screens after changes
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful work 👏
…es-changes � Conflicts: � packages/expo-av/CHANGELOG.md
Hello. Could you help? So what do I need to put now if I've got this at the moment:
|
Hi @lpgm, you need to use import { InterruptionModeIOS } from 'expo-av';
interruptionModeIOS: InterruptionModeIOS.DoNotMix; Also it looks like However, this change has been mentioned in package changelog, where the current enum names were listed: |
Thanks a lot, @Simek . I was directed to that changelog, but I wasn't sure about the format of what was needed. |
Why
This PR starts the effort to prepare the
Audio
module for the docs autogeneration.There will be more breaking changes to come in the future PRs, see:
How
The first parts refactors the interruption modes constants to the newly added
InterruptionModeAndroid
andInterruptionModeIOS
enum types.I have also spotted during fixes for NCL screens, that
AudioMode
type is not properly exported byav
package, which forced users to define those object types manually. This problem also has been fixed, and for the clarity, I have moved all the Audio related types to the newAudio.types.ts
file.Test Plan
yarn
andyarn lint
commands ended with a success.NCL apps build and runs on the iOS device. Audio screen are working as expected.
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).