[cli][start] Added interstitial middleware #16560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
ide
requested changes
Mar 12, 2022
packages/expo/cli/start/server/middleware/InterstitialPageMiddleware.ts
Outdated
Show resolved
Hide resolved
packages/expo/cli/start/server/middleware/InterstitialPageMiddleware.ts
Outdated
Show resolved
Hide resolved
| // Production: This will resolve when installed in the project. | ||
| resolveFrom.silent(this.projectRoot, 'expo/static/loading-page/index.html') ?? | ||
| // Development: This will resolve when testing locally. | ||
| require.resolve('../../../../../static/loading-page/index.html'); |
There was a problem hiding this comment.
No need for require.resolve -- use path.resolve(__dirname, stuff). That said, path.join(require.resolve('expo'), 'static/loading-page/index.html') may work and be more robust.
packages/expo/cli/start/server/middleware/InterstitialPageMiddleware.ts
Outdated
Show resolved
Hide resolved
packages/expo/cli/start/server/middleware/__tests__/InterstitialPageMiddleware-test.ts
Show resolved
Hide resolved
packages/expo/cli/start/server/middleware/__tests__/InterstitialPageMiddleware-test.ts
Outdated
Show resolved
Hide resolved
packages/expo/cli/start/server/middleware/RuntimeRedirectMiddleware.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: James Ide <ide@users.noreply.github.com>
EvanBacon
force-pushed
the
@evanbacon/expo/cli/start/interstitial-middleware
branch
from
0a037b0
to
69796a5
Compare
…eware.ts Co-authored-by: James Ide <ide@users.noreply.github.com>
ide
requested changes
Mar 14, 2022
3 tasks
Co-authored-by: James Ide <ide@users.noreply.github.com>
|
Fixed icon
|
ide
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Test Plan