Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Added Metro dev server module #16631

Merged
merged 11 commits into from
Mar 16, 2022
Merged

[cli] Added Metro dev server module #16631

merged 11 commits into from
Mar 16, 2022

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Mar 14, 2022 •
edited

Why

How

  • Implements a general bundler dev server module which we extend to add Metro support.
  • For PR simplicity the logging, and webpack parts of this PR have been omitted.

Test Plan

  • Added tests.

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@EvanBacon EvanBacon requested review from ide and byCedric March 14, 2022 22:31
@EvanBacon EvanBacon requested a review from tsapeta as a code owner March 14, 2022 22:31
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 14, 2022
@EvanBacon @expo-bot
Update packages/expo/CHANGELOG.md
0a0d6f3 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 14, 2022
ide
ide requested changes Mar 15, 2022
View reviewed changes
packages/expo/cli/start/server/BundlerDevServer.ts Outdated Show resolved Hide resolved
packages/expo/cli/start/server/DevServerManager.ts Show resolved Hide resolved
packages/expo/cli/start/server/DevServerManager.ts Outdated Show resolved Hide resolved
packages/expo/cli/start/server/DevServerManager.ts Outdated Show resolved Hide resolved
packages/expo/cli/start/server/DevServerManager.ts Outdated Show resolved Hide resolved
packages/expo/cli/start/server/BundlerDevServer.ts Outdated Show resolved Hide resolved
packages/expo/cli/start/server/BundlerDevServer.ts Outdated Show resolved Hide resolved
packages/expo/cli/start/server/BundlerDevServer.ts Outdated Show resolved Hide resolved
packages/expo/cli/start/server/BundlerDevServer.ts Outdated Show resolved Hide resolved
packages/expo/cli/start/server/BundlerDevServer.ts Show resolved Hide resolved
@EvanBacon EvanBacon requested a review from ide March 15, 2022 20:46
ide
ide approved these changes Mar 16, 2022
View reviewed changes
packages/expo/cli/start/server/BundlerDevServer.ts Outdated Show resolved Hide resolved
packages/expo/cli/start/server/BundlerDevServer.ts Outdated Show resolved Hide resolved
packages/expo/cli/start/server/BundlerDevServer.ts Outdated Show resolved Hide resolved
EvanBacon and others added 3 commits March 16, 2022 00:47
@EvanBacon @ide
Update packages/expo/cli/start/server/BundlerDevServer.ts
754e632 
Co-authored-by: James Ide <ide@users.noreply.github.com>
@EvanBacon @ide
Update packages/expo/cli/start/server/BundlerDevServer.ts
5be370c 
Co-authored-by: James Ide <ide@users.noreply.github.com>
@EvanBacon @ide
Update packages/expo/cli/start/server/BundlerDevServer.ts
103bfd8 
Co-authored-by: James Ide <ide@users.noreply.github.com>
@EvanBacon EvanBacon merged commit 814d9ad into main Mar 16, 2022
@EvanBacon EvanBacon deleted the @evanbacon/expo/cli/start/metro-dev-server branch March 16, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ide ide ide approved these changes

@byCedric byCedric Awaiting requested review from byCedric

@tsapeta tsapeta Awaiting requested review from tsapeta tsapeta is a code owner

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @ide @expo-bot