Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-launcher] add organizations to account selector #18152

Merged
merged 3 commits into from
Jul 8, 2022

Conversation

ajsmth
Copy link
Contributor

@ajsmth ajsmth commented Jul 7, 2022

Why

Closes ENG-5279

A user recently reported not seeing their org on this selector

The selector doesn't do much at the moment other than sync with the CLI to determine a local packager IP but it makes sense to put these in there to have some kind of parity with the site

How

Updated the rendering logic to display organizations in this selector
Updated the app header to account for an empty image and include a small label for the organization name

Sidenote: I had to add a babel plugin to get the bundler to work w/ the latest updates to reanimated

Test Plan

Screenshots:
Screen Shot 2022-07-07 at 12 54 32 PM
Screen Shot 2022-07-07 at 1 14 20 PM

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@ajsmth ajsmth requested a review from esamelson July 7, 2022 20:15
@ajsmth ajsmth requested a review from lukmccall as a code owner July 7, 2022 20:15
@linear
Copy link

linear bot commented Jul 7, 2022

ENG-5279 Add organizations to account selector

There are potentially more user types to show here (like on the website) that the user might want to choose from

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jul 7, 2022
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jul 7, 2022
Copy link
Contributor

@esamelson esamelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ajsmth ajsmth merged commit a323ef3 into main Jul 8, 2022
@ajsmth ajsmth deleted the andrew/eng-5279-add-organizations-to-account-selector branch July 8, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants