[dev-launcher][ios] fix deferred deep links #18614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-5284 iOS deferred deep link popup shows multiple times
This popup seems a bit buggy - sometimes it shows the popup a few times, sometimes it continues to pop up and show a previously handled deep link - I think we should spent some time cleaning this up |
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Aug 12, 2022
lukmccall
pushed a commit
that referenced
this pull request
Aug 16, 2022
Ddv0623
pushed a commit
to preciofishbone/expo
that referenced
this pull request
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-5284
The issue outlines some strange / annoying popup behaviour with the deep link modal in the dev launcher.
After taking a closer look, it was actually a symptom of these deep links never being passed through properly, so these deferred deep links were not actually working:
Simulator.Screen.Recording.-.iPhone.12.-.2022-08-11.at.12.19.06.mp4
How
In the
didStartWithSuccessmethod of the delegate handler, we now loop over the initial launch options and any additional launch options captured by theEXDevLauncherController- this assumes that more recent deep links captured by the deep link registry will potentially override the initial url that the app might be launched with - I figured this was the most sensible approachTest Plan
Deep links are now properly captured, passed to the app instance, and are consumed:
Simulator.Screen.Recording.-.iPhone.12.-.2022-08-11.at.12.21.23.mp4
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).