Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-launcher][ios] fix deferred deep links #18614

Merged
merged 2 commits into from
Aug 15, 2022
Merged

[dev-launcher][ios] fix deferred deep links #18614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
505274c
[dev-launcher][ios] fix deferred deep links
ajsmth Aug 11, 2022
012233c
lint and changelog
ajsmth Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/expo-dev-launcher/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
### 🐛 Bug fixes

- Fixed `the function must be called on main queue` error when the app is reload from the error screen on iOS. ([#18563](https://github.com/expo/expo/pull/18563) by [@lukmccall](https://github.com/lukmccall))
- Fix deferred deep link handling on iOS. ([#18614](https://github.com/expo/expo/pull/18614)) by [@ajsmth](https://github.com/ajsmth)

### 💡 Others

Expand Down
14 changes: 13 additions & 1 deletion ...ages/expo-dev-launcher/ios/ReactDelegateHandler/ExpoDevLauncherReactDelegateHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,19 @@ public class ExpoDevLauncherReactDelegateHandler: ExpoReactDelegateHandler, RCTB
// MARK: EXDevelopmentClientControllerDelegate implementations

public func devLauncherController(_ developmentClientController: EXDevLauncherController, didStartWithSuccess success: Bool) {
let bridge = RCTBridge(delegate: self.bridgeDelegate, launchOptions: self.launchOptions)
var launchOptions: [AnyHashable: Any] = [:]

if let initialLaunchOptions = self.launchOptions {
for (key, value) in initialLaunchOptions {
launchOptions[key] = value
}
}

for (key, value) in developmentClientController.getLaunchOptions() {
launchOptions[key] = value
}

let bridge = RCTBridge(delegate: self.bridgeDelegate, launchOptions: launchOptions)
developmentClientController.appBridge = bridge

let rootView = RCTRootView(bridge: bridge!, moduleName: self.rootViewModuleName!, initialProperties: self.rootViewInitialProperties)
Expand Down