Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): updated readme #18663

Merged
merged 4 commits into from Aug 17, 2022
Merged

chore(cli): updated readme #18663

merged 4 commits into from Aug 17, 2022

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Aug 16, 2022

Why

update the readme to capture more SEO and be a bit closer to what we had with https://github.com/expo/expo-cli

How

Import SVGs and add star repo notice

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Aug 16, 2022
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Aug 16, 2022
@Simek
Copy link
Collaborator

Simek commented Aug 16, 2022

If I did not stated this before I really like the animated CLI banner Evan! 🙂

What do you think about moving the banner file to https://github.com/expo/expo/tree/main/.github/resources, to have readme
or GitHub related images in one place?

@EvanBacon EvanBacon requested a review from Simek August 16, 2022 20:42
@EvanBacon EvanBacon merged commit df49d6e into main Aug 17, 2022
@EvanBacon EvanBacon deleted the @evanbacon/cli/update-docs branch August 17, 2022 12:35
Ddv0623 pushed a commit to preciofishbone/expo that referenced this pull request Sep 26, 2022
* updated readme

* Delete float-box.svg

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

* move CLI banner

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants