Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expo): drop console.warn and console.error wrappers #18983

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

EvanBacon
Copy link
Contributor

Why

  • We shouldn't need to hide LottieAnimationView warnings anymore.
  • All Warning: .* has been extracted errors have been removed from the expo package.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 4, 2022
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 4, 2022
@EvanBacon EvanBacon merged commit 06a358f into main Sep 5, 2022
@EvanBacon EvanBacon deleted the @evanbacon/expo/drop-log-wrapper branch September 5, 2022 01:10
Ddv0623 pushed a commit to preciofishbone/expo that referenced this pull request Sep 26, 2022
* feat(expo): drop console.warn and console.error wrappers

* Update packages/expo/CHANGELOG.md

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants