Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expo): drop dev container side effect #18984

Merged
merged 12 commits into from
Oct 24, 2022

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Sep 4, 2022

Why

How

  • Move DevLoadingView into withDevTools (formerly withExpo).
  • Add displayName for withDevTools that follows React/React Native convention for wrapper views.
  • Drop various platform-specific files and consolidate wrapper view.

Test Plan

  • TBD

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 4, 2022
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 5, 2022
@EvanBacon EvanBacon marked this pull request as ready for review September 6, 2022 15:28
Copy link
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to test that initialProps are passed in since this code passes them into only the Wrapper component: https://github.com/facebook/react-native/blob/12e5842e11ecd53755f43e99c592135b58ac694b/Libraries/ReactNative/AppContainer.js#L117

packages/expo/src/launch/withRestoration.tsx Outdated Show resolved Hide resolved
packages/expo/src/launch/withRestoration.tsx Outdated Show resolved Hide resolved
packages/expo/src/launch/withRestoration.tsx Outdated Show resolved Hide resolved
packages/expo/src/Expo.fx.tsx Show resolved Hide resolved
packages/expo/src/launch/withRestoration.tsx Outdated Show resolved Hide resolved
packages/expo/src/launch/withRestoration.tsx Outdated Show resolved Hide resolved
packages/expo/src/launch/withDevTools.tsx Outdated Show resolved Hide resolved
packages/expo/src/launch/withDevTools.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants