-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expo): drop dev container side effect #18984
Merged
EvanBacon
merged 12 commits into
main
from
@evanbacon/expo/drop-dev-container-side-effect
Oct 24, 2022
Merged
feat(expo): drop dev container side effect #18984
EvanBacon
merged 12 commits into
main
from
@evanbacon/expo/drop-dev-container-side-effect
Oct 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Sep 5, 2022
ide
requested changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to test that initialProps are passed in since this code passes them into only the Wrapper component: https://github.com/facebook/react-native/blob/12e5842e11ecd53755f43e99c592135b58ac694b/Libraries/ReactNative/AppContainer.js#L117
tsapeta
approved these changes
Sep 28, 2022
ide
approved these changes
Sep 29, 2022
Co-authored-by: James Ide <ide@users.noreply.github.com>
brentvatne
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
react-native
How
DevLoadingView
intowithDevTools
(formerlywithExpo
).withDevTools
that follows React/React Native convention for wrapper views.Test Plan
Checklist
expo prebuild
& EAS Build (eg: updated a module plugin).