Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo] bump bundled version of react-native-svg #19080

Closed
wants to merge 1 commit into from
Closed

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Sep 12, 2022

Why

Fixes #19013

How

Bump bundled react-native-svg to the latest release from 12 major via et uvm.

Test Plan

NCL app was starting correctly after performing a bump.

Checklist

@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 1473c3a

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 12, 2022
@@ -20,7 +20,7 @@
/**
* returns the distance between two points
*/
CGFloat distance(CGPoint p1, CGPoint p2)
static CGFloat distance(CGPoint p1, CGPoint p2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why is this change required?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why is there no Android counterpart?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes are fetched from the package repo, so you need to ask this question in there or look through the changelog/ source file blame:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Simek Simek closed this Oct 9, 2022
@Simek Simek deleted the simek/rn-svg-bump branch October 9, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React-native-svg typescript errors.
3 participants