Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo] bump bundled version of react-native-svg #19080

Closed
wants to merge 1 commit into from
Closed

[expo] bump bundled version of react-native-svg #19080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/bare-expo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
"react-native-safe-area-context": "4.3.1",
"react-native-screens": "~3.15.0",
"react-native-shared-element": "0.8.4",
"react-native-svg": "12.3.0",
"react-native-svg": "12.4.4",
"react-native-view-shot": "3.3.0",
"react-native-webview": "11.22.4",
"test-suite": "*"
Expand Down
2 changes: 1 addition & 1 deletion apps/native-component-list/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
"react-native-safe-area-view": "^0.14.8",
"react-native-screens": "~3.15.0",
"react-native-shared-element": "0.8.4",
"react-native-svg": "12.3.0",
"react-native-svg": "12.4.4",
"react-native-view-shot": "3.3.0",
"react-native-web": "~0.18.7",
"react-native-webview": "11.22.4",
Expand Down
4 changes: 2 additions & 2 deletions ios/Exponent/Versioned/Core/Api/Components/Svg/Utils/RNSVGPathMeasure.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/**
* returns the distance between two points
*/
CGFloat distance(CGPoint p1, CGPoint p2)
static CGFloat distance(CGPoint p1, CGPoint p2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why is this change required?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why is there no Android counterpart?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes are fetched from the package repo, so you need to ask this question in there or look through the changelog/ source file blame:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR adding those changes is here:

{
CGFloat dx = p2.x - p1.x;
CGFloat dy = p2.y - p1.y;
Expand Down Expand Up @@ -58,7 +58,7 @@ CGFloat distance(CGPoint p1, CGPoint p2)
* ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
*/
void subdivideBezierAtT(const CGPoint bez[4], CGPoint bez1[4], CGPoint bez2[4], CGFloat t)
static void subdivideBezierAtT(const CGPoint bez[4], CGPoint bez1[4], CGPoint bez2[4], CGFloat t)
{
CGPoint q;
CGFloat mt = 1 - t;
Expand Down
2 changes: 1 addition & 1 deletion packages/expo-stories/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"react-native-gesture-handler": "~2.5.0",
"react-native-safe-area-context": "4.3.1",
"react-native-screens": "~3.15.0",
"react-native-svg": "12.3.0",
"react-native-svg": "12.4.4",
"sane": "^5.0.1"
}
}
2 changes: 1 addition & 1 deletion packages/expo/bundledNativeModules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
"react-native-safe-area-context": "4.3.1",
"react-native-screens": "~3.15.0",
"react-native-shared-element": "0.8.4",
"react-native-svg": "12.3.0",
"react-native-svg": "12.4.4",
"react-native-view-shot": "3.3.0",
"react-native-webview": "11.23.0",
"sentry-expo": "~5.0.0",
Expand Down