Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo] Fix LottieAnimationViewManager not found error #19439

Merged
merged 2 commits into from
Oct 7, 2022
Merged

[expo] Fix LottieAnimationViewManager not found error #19439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0917ab
[expo] Fix LottieAnimationViewManager not found error
Kudo Oct 6, 2022
6aafbbe
update changelog
Kudo Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/expo/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### 🐛 Bug fixes

- Fixed `LottieAnimationViewManager isn't supported in Expo Go` error when running with `lottie-react-native`. ([#19439](https://github.com/expo/expo/pull/19439) by [@kudo](https://github.com/kudo))

### 💡 Others

## 47.0.0-alpha.1 — 2022-10-06
Expand Down
2 changes: 1 addition & 1 deletion packages/expo/build/proxies/NativeModules.d.ts.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/expo/build/proxies/NativeModules.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo/build/proxies/NativeModules.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/expo/src/proxies/NativeModules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const PROPS_TO_IGNORE: Set<string> = new Set([
'RNGetRandomValues',
'RNVectorIconsManager',
'RNVectorIconsModule',
'LottieAnimationViewManager', // False alarm from lottie where it uses react-native-safe-module to detect corresponding native module, but it doesn't exist in lottie.
/**
* Other methods that can be called on the NativeModules object that we should ignore. The
* underlying NativeModules object is sometimes a proxy itself so may not have these methods
Expand Down