[docs][audio] update example to help users avoid disabling speaker #19621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-kurak
requested review from
Simek,
amandeepmittal,
kbrandwijk,
barthap and
Kudo
as code owners
Simek
reviewed
Oct 20, 2022
Simek
approved these changes
Oct 20, 2022
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
keith-kurak
deleted the
keith/clarify-audio-mode-requirements-for-ios-recording
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This issue with audio playing through the earpiece after recording trips folks up all the time. This updates the example to include and highlight the relevant code to keep that from happening. Also updates the function description to match similar wording in the Android section (e.g., "earpiece").
Test Plan
Made sure the docs look OK. Wasn't sure the it was worth actually recommitting the API documentation just for this for previous versions, but figured it'd at least be picked up in the future.