Add iOS simulator fallback for UTType #19669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Oct 24, 2022
packages/expo-media-library/ios/EXMediaLibrary/EXMediaLibrary.m
Outdated
Show resolved
Hide resolved
packages/expo-media-library/ios/EXMediaLibrary/EXMediaLibrary.m
Outdated
Show resolved
Hide resolved
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
tsapeta
approved these changes
Oct 24, 2022
packages/expo-media-library/ios/EXMediaLibrary/EXMediaLibrary.m
Outdated
Show resolved
Hide resolved
|
@tsapeta - can ensure that this lands before ios versioning? |
brentvatne
approved these changes
Oct 24, 2022
|
Ci for check packages fails due to #19621 on main, so unrelated issue. Tested the new non-deprecated method on device. |
aleqsio
deleted the
aleksandermikucki/eng-6795-fix-medialibrarysavetolibraryasync
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #16383
It seems this line doesn't work on iOS simulator on M1 macs when the app is run through Rosetta (as Expo GO is):
It seems that this is a common issue:
ionic-team/capacitor#4903
https://developer.apple.com/forums/thread/685968
https://developer.apple.com/forums/thread/702933
The
UTTypeCreatePreferredIdentifierForTagmethod is also deprecated.Unfortunately, changing to the non-deprecated
[UTType typeWithFilenameExtension]also returns nil on M1 simulator.How
We can do a lookup table for mapping extensions to media types if iOS functions return nil.
Test Plan
I've tested the fallback code on iOS simulator.
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).