[NCL] Fix skia web support

[Kudo]

Why

ncl doesn't support @shopify/react-native-skia on web and publishing ci job is also failed: https://github.com/expo/expo/actions/runs/3313396371/jobs/5471317891
close ENG-6839

How

• add WithSkiaWeb wrapper for web to wait for canvaskit loading
• add dangerouslyAddModulePathsToTranspile to transpile skia files for the nullish coalescing operators

Test Plan

• ncl on web + skia
• for publish ncl web ci, test yarn build:web

Checklist

• n/a Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
• Conforms with the Documentation Writing Style Guide
• This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

[Simek]

@EvanBacon Do you think is there a different way we can fix that, or support nullish coalescing on Web, which will work out-of-the box for other libraries? Refs: #19677.

[EvanBacon]

@Simek transpiling node modules is something we always want to do less of. The node modules should be shipped pre-transpiled.

[Simek]

Yeah, make sense. I will add the note about this config overwrite to our docs, since the Skia seems to recommend another approach to tackle web:

• https://shopify.github.io/react-native-skia/docs/getting-started/web

[gabrieldonadel]

Yeah, make sense. I will add the note about this config overwrite to our docs

@Simek @EvanBacon Just suggesting here but I found that many of the libs not compatible with Expo web are just lacking this pre-transpilation step and having docs about that (maybe a guide?) would be super nice. I am available to help you folks if that's ok as well

[Simek]

I think that you will need to revert 66c59ea in this changeset now @Kudo.

@gabrieldonadel It would be awesome if you can help with that, I think that we should add the note about web config in the Installation section of https://docs.expo.dev/versions/latest/sdk/skia/ page. We don't have the general web troubleshooting guide or page, but maybe this additional config overwrite can also be mentioned on https://docs.expo.dev/guides/customizing-webpack/ page.

[Kudo]

after revisiting the skia issue, it does actually go through some transpile process when publishing package on npm. they use react-native-builder-blob to build typescript into esm and commonjs. ideally they could transpile the nullish coalescing operators, so user don't have to add the dangerouslyAddModulePathsToTranspile in their config. i could create an issue for them.

i will merge this pr and revert 66c59ea first for sdk release.

[Kudo]

close ENG-6839

[linear]

ENG-6839 Fix NCL build error for web

https://github.com/expo/expo/actions/runs/3342388415/jobs/5534562019

We should revert this when fixing: 66c59ea

[Kudo]

Shopify/react-native-skia#1030