Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add note to Skia docs about web installation #19785

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

gabrieldonadel
Copy link
Member

Why

Currently the Skia instructions on the Expo documentation website can be a bit misleading as they don't mention any extra steps necessary in order to use Skia with Expo web. Related to #19717

How

This PR updates the Skia documentation to include instructions about the additional steps that need to be followed to use Skia on web

Test Plan

Changes have been tested by running docs repo locally and visiting: http://localhost:3002/versions/latest/sdk/skia/

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Oct 31, 2022
Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

docs/pages/versions/v46.0.0/sdk/skia.mdx Outdated Show resolved Hide resolved
docs/pages/versions/unversioned/sdk/skia.mdx Outdated Show resolved Hide resolved
docs/pages/versions/v47.0.0/sdk/skia.mdx Outdated Show resolved Hide resolved
Co-authored-by: Brent Vatne <brentvatne@gmail.com>
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow up! 👍

@Simek Simek merged commit 89249b4 into expo:main Nov 2, 2022
@gabrieldonadel gabrieldonadel deleted the docs/add-note-about-skia-on-web branch November 2, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants