Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modules][Android] Improve error messages in view events #19725

Merged
merged 1 commit into from Oct 27, 2022

Conversation

lukmccall
Copy link
Contributor

Why

Improves error messages connected with view events.

@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against cf7806e

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 27, 2022
@lukmccall lukmccall merged commit f4fd31d into main Oct 27, 2022
@lukmccall lukmccall deleted the @lukmccall/core/improve-view-events-error-messages branch October 27, 2022 15:59
lukmccall added a commit that referenced this pull request Oct 28, 2022
lukmccall added a commit that referenced this pull request Oct 28, 2022
# Why

Backports #19723 and #19725 to sdk-47 versioned code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants