Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modules][Android] Improve error messages in view events #19725

Merged
merged 1 commit into from
Oct 27, 2022
Merged

[modules][Android] Improve error messages in view events #19725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...xpo-modules-core/android/src/main/java/expo/modules/kotlin/viewevent/ViewEventDelegate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ class ViewEventDelegate<T>(

operator fun getValue(thisRef: View, property: KProperty<*>): ViewEventCallback<T> {
if (!isValidated) {
throw IllegalStateException("You have to export this property as a callback in the `ViewManager`.")
throw IllegalStateException("You have to export '${property.name}' property as a event in the `View` component")
}

val view = viewHolder.get()
?: throw IllegalStateException("Can't send an event from the view that is deallocated.")
?: throw IllegalStateException("Can't send the '${property.name}' event from the view that is deallocated")
return ViewEvent(property.name, type, view, coalescingKey)
}
}
Expand Down