-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android][tools] add sdk 48 versioned code #21076
Conversation
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇 ❌ Error: Forbidden file size or format
Generated by ExpoBot 🤖 against 4058e98 |
it's a big pr for the first commit. please review by commits. it would be easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the upload automatic? Maybe there is a GitHub API to do so 🤔
creating a git tag and a github release is a prerequisite for uploading, we will do that near to sdk release. but we will try versioning much more frequently than that. so i was thinking to upload manually. |
Why
add android sdk 48 versioned code
How
et add-sdk -p android -s 48.0.0
et android-download-versioned-aars
to download aars before gradle building.Test Plan
Checklist
expo prebuild
& EAS Build (eg: updated a module plugin).