Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][tools] add sdk 48 versioned code #21076

Merged
merged 7 commits into from
Feb 6, 2023

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Feb 3, 2023

Why

add android sdk 48 versioned code

How

  • et add-sdk -p android -s 48.0.0
  • there is a big problem for versioning this time where versioned aar size is from ~17MB to ~131MB because of prefab, so it's not able to commit to git. this pr proposes to upload versioned aar to github and having an et android-download-versioned-aars to download aars before gradle building.

Test Plan

  • sdk 48 android versioned expo go + sdk 48 ncl smoking test
  • ci passed

Checklist

@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Feb 3, 2023
@expo-bot
Copy link
Collaborator

expo-bot commented Feb 3, 2023

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Forbidden file size or format


Generated by ExpoBot 🤖 against 4058e98

@Kudo Kudo marked this pull request as ready for review February 3, 2023 14:18
@Kudo Kudo requested a review from tsapeta as a code owner February 3, 2023 14:18
@Kudo Kudo requested a review from lukmccall February 3, 2023 14:18
@Kudo
Copy link
Contributor Author

Kudo commented Feb 3, 2023

it's a big pr for the first commit. please review by commits. it would be easier.

Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the upload automatic? Maybe there is a GitHub API to do so 🤔

@Kudo
Copy link
Contributor Author

Kudo commented Feb 4, 2023

Can we make the upload automatic? Maybe there is a GitHub API to do so 🤔

creating a git tag and a github release is a prerequisite for uploading, we will do that near to sdk release. but we will try versioning much more frequently than that. so i was thinking to upload manually.

@Kudo Kudo merged commit ab11e3c into main Feb 6, 2023
@Kudo Kudo deleted the @kudo/sdk48/android-versioned-code branch February 6, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants