-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metro-config): add postcss #22032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
EvanBacon
commented
Apr 6, 2023
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Apr 6, 2023
EvanBacon
requested review from
Simek,
amandeepmittal and
kbrandwijk
as code owners
April 10, 2023 13:28
expo-bot
added
bot: suggestions
ExpoBot has some suggestions
and removed
bot: passed checks
ExpoBot has nothing to complain about
labels
Apr 10, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Apr 10, 2023
@EvanBacon This appears to be crashing builds when using EAS in a pnpm monorepo. I think this is relying on a phantom undeclared dependency on edit: on expo 49.0.0-beta.0 [RUN_GRADLEW] > Task :app:createBundleReleaseJsAndAssets FAILED
[RUN_GRADLEW] Error: Cannot find module 'metro-cache'
[RUN_GRADLEW] Require stack:
[RUN_GRADLEW] - /Users/imagio/Library/pnpm/global/5/.pnpm/@expo+metro-config@0.10.3/node_modules/@expo/metro-config/build/transform-worker/postcss.js
[RUN_GRADLEW] - /Users/imagio/Library/pnpm/global/5/.pnpm/@expo+metro-config@0.10.3/node_modules/@expo/metro-config/build/ExpoMetroConfig.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/start/server/metro/resolveFromProject.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/utils/analytics/getMetroProperties.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/start/server/metro/instantiateMetro.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/export/embed/exportEmbedAsync.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/export/embed/index.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/bin/cli
[RUN_GRADLEW] Error: Cannot find module 'metro-cache'
[RUN_GRADLEW] Require stack:
[RUN_GRADLEW] - /Users/imagio/Library/pnpm/global/5/.pnpm/@expo+metro-config@0.10.3/node_modules/@expo/metro-config/build/transform-worker/postcss.js
[RUN_GRADLEW] - /Users/imagio/Library/pnpm/global/5/.pnpm/@expo+metro-config@0.10.3/node_modules/@expo/metro-config/build/ExpoMetroConfig.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/start/server/metro/resolveFromProject.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/utils/analytics/getMetroProperties.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/start/server/metro/instantiateMetro.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/export/embed/exportEmbedAsync.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/export/embed/index.js
[RUN_GRADLEW] - /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/bin/cli
[RUN_GRADLEW] at Module._resolveFilename (node:internal/modules/cjs/loader:1075:15)
[RUN_GRADLEW] at Module._load (node:internal/modules/cjs/loader:920:27)
[RUN_GRADLEW] at Module.require (node:internal/modules/cjs/loader:1141:19)
[RUN_GRADLEW] at require (node:internal/modules/cjs/helpers:110:18)
[RUN_GRADLEW] at getPostcssConfigHash (/Users/imagio/Library/pnpm/global/5/.pnpm/@expo+metro-config@0.10.3/node_modules/@expo/metro-config/build/transform-worker/postcss.js:242:7)
[RUN_GRADLEW] at getDefaultConfig (/Users/imagio/Library/pnpm/global/5/.pnpm/@expo+metro-config@0.10.3/node_modules/@expo/metro-config/build/ExpoMetroConfig.js:281:56)
[RUN_GRADLEW] at Object.loadAsync (/Users/imagio/Library/pnpm/global/5/.pnpm/@expo+metro-config@0.10.3/node_modules/@expo/metro-config/build/ExpoMetroConfig.js:304:23)
[RUN_GRADLEW] at Object.loadMetroConfigAsync (/private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/start/server/metro/instantiateMetro.js:47:40)
[RUN_GRADLEW] at exportEmbedAsync (/private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/export/embed/exportEmbedAsync.js:12:54)
[RUN_GRADLEW] at /private/var/folders/gx/fwg565ys3177ht4tnx40wqv80000gn/T/eas-build-local-nodejs/13cda27c-eab6-4f56-9ee8-025b975f0361/build/node_modules/.pnpm/@expo+cli@0.10.4_expo-modules-autolinking@1.5.0/node_modules/@expo/cli/build/src/export/embed/index.js:112:16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
postcss
parser which loads the user config.postcss.config.js
andpostcss.config.json
are the only supported config files. https://github.com/webpack-contrib/postcss-loader/blob/ef332db57381ed1d8aaa4a9a20eec0e0b21fdb7c/src/utils.js#L64-L114Test Plan
Checklist
expo prebuild
& EAS Build (eg: updated a module plugin).