[dev-launcher][dev-menu][ios] Add support for Fabric #22184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-menu
branch
from
96d290e
to
1e36989
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-menu
branch
from
1e36989
to
b83ea26
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-menu
branch
from
b83ea26
to
d499285
Compare
gabrieldonadel
changed the base branch from
main
to
@gabrieldonadel/migrate-launcher-to-new-api-on-ios
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-menu
branch
2 times, most recently
from
4398423
to
57e4694
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/migrate-launcher-to-new-api-on-ios
branch
2 times, most recently
from
00a6d77
to
147365e
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-menu
branch
from
57e4694
to
5f3dc7c
Compare
Base automatically changed from
@gabrieldonadel/migrate-launcher-to-new-api-on-ios
to
main
May 19, 2023 15:25
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-menu
branch
4 times, most recently
from
1af9ce9
to
46e854d
Compare
expo-bot
added
bot: needs changes
gabrieldonadel
commented
May 22, 2023
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-menu
branch
5 times, most recently
from
369e701
to
60f711f
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-menu
branch
from
60f711f
to
f6a6352
Compare
gabrieldonadel
changed the title
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-menu
branch
3 times, most recently
from
e435874
to
8b13174
Compare
Co-authored-by: Kudo Chien <kudo@expo.dev>
Closes ENG-7955 This PR is Part 2 of a series of PRs that will add dev-launcher support for the new architecture. Part 1 #22184 - Fix `EXDevLauncherBridgeDelegate` not able to relaunch DevLauncher - Add `ExpoDevLauncherBridgeDelegateHandler` to handle opening apps from `ExpoDevLauncherReactDelegateHandler` - Update `openDevMenuFromReactNative` to ensure the DevMenu is closed before opening the react-native dev menu Run `fabric-tester` and `bare-expo` on iOS <table> <tr><th>fabric-tester</th><th>bare-expo</th></tr> <tr> <td> <video src="https://github.com/expo/expo/assets/11707729/69e80f31-3d8e-4135-afd7-0f4264052a79"/> </td> <td> <video src="https://github.com/expo/expo/assets/11707729/99b10d00-45b3-4b3e-b7c0-2cc7599ebad7" /> </td> </tr> </table> <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-menu
branch
from
97369b6
to
b660581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-7955
This PR adds dev-launcher support for the new architecture.
How
expo-dev-launcherandexpo-dev-menupodspecs to supportNEW_ARCH_ENABLEDflagsEXDevLauncherBridgeDelegateclass that inherits fromRCTAppDelegateand is responsible for creating the root view and bridgeDevMenuRCTCxxBridgeDelegatewithDevMenuRCTAppDelegateEXDevLauncherBridgeDelegatenot able to relaunch DevLauncherExpoDevLauncherBridgeDelegateHandlerto handle opening apps fromExpoDevLauncherReactDelegateHandleropenDevMenuFromReactNativeto ensure the DevMenu is closed before opening the react-native dev menuTest Plan
Run
fabric-testerandbare-expoon iOSScreen.Recording.2023-06-09.at.15.44.03.mov
Screen.Recording.2023-06-09.at.16.23.04.mov
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).