[dev-launcher][dev-menu][ios] Add support for Fabric - Part 2 #22821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-client-part-2
branch
from
b663572
to
7550be1
Compare
3 tasks
gabrieldonadel
commented
Jun 13, 2023
Kudo
reviewed
Jun 14, 2023
| @@ -43,15 +43,14 @@ public class ExpoDevLauncherReactDelegateHandler: ExpoReactDelegateHandler, RCTB | |||
| ExpoDevMenuReactDelegateHandler.enableAutoSetup = false | |||
|
|
|||
| self.reactDelegate = reactDelegate | |||
| self.bridgeDelegate = EXRCTBridgeDelegateInterceptor(bridgeDelegate: bridgeDelegate, interceptor: self) | |||
There was a problem hiding this comment.
without the EXRCTBridgeDelegateInterceptor, does the current solution support user's custom delegate in AppDelegate, e.g. if there are custom extraModulesForBridge:?
There was a problem hiding this comment.
Good question, let me double check if that still works as expected
There was a problem hiding this comment.
Hi @Kudo, you were right about this, the current implementation is not working as expected, do you think it would be ok to pass interceptor as ExpoDevLauncherBridgeDelegateHandler?
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-menu
branch
2 times, most recently
from
5487f4f
to
7130a62
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/fabric-ios-dev-client-part-2
branch
from
8a780f9
to
1aa28f8
Compare
|
I'm merging this into #22184 as this PR ended up not being as big as I expected |
gabrieldonadel
merged commit ba40903
into
@gabrieldonadel/fabric-ios-dev-menu
7 checks passed
gabrieldonadel
added a commit
that referenced
this pull request
Jun 16, 2023
Closes ENG-7955 This PR is Part 2 of a series of PRs that will add dev-launcher support for the new architecture. Part 1 #22184 - Fix `EXDevLauncherBridgeDelegate` not able to relaunch DevLauncher - Add `ExpoDevLauncherBridgeDelegateHandler` to handle opening apps from `ExpoDevLauncherReactDelegateHandler` - Update `openDevMenuFromReactNative` to ensure the DevMenu is closed before opening the react-native dev menu Run `fabric-tester` and `bare-expo` on iOS <table> <tr><th>fabric-tester</th><th>bare-expo</th></tr> <tr> <td> <video src="https://github.com/expo/expo/assets/11707729/69e80f31-3d8e-4135-afd7-0f4264052a79"/> </td> <td> <video src="https://github.com/expo/expo/assets/11707729/99b10d00-45b3-4b3e-b7c0-2cc7599ebad7" /> </td> </tr> </table> <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
gabrieldonadel
added a commit
that referenced
this pull request
Jun 19, 2023
Closes ENG-7955 This PR is Part 2 of a series of PRs that will add dev-launcher support for the new architecture. Part 1 #22184 - Fix `EXDevLauncherBridgeDelegate` not able to relaunch DevLauncher - Add `ExpoDevLauncherBridgeDelegateHandler` to handle opening apps from `ExpoDevLauncherReactDelegateHandler` - Update `openDevMenuFromReactNative` to ensure the DevMenu is closed before opening the react-native dev menu Run `fabric-tester` and `bare-expo` on iOS <table> <tr><th>fabric-tester</th><th>bare-expo</th></tr> <tr> <td> <video src="https://github.com/expo/expo/assets/11707729/69e80f31-3d8e-4135-afd7-0f4264052a79"/> </td> <td> <video src="https://github.com/expo/expo/assets/11707729/99b10d00-45b3-4b3e-b7c0-2cc7599ebad7" /> </td> </tr> </table> <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-7955
This PR is Part 2 of a series of PRs that will add dev-launcher support for the new architecture.
Part 1 #22184
How
EXDevLauncherBridgeDelegatenot able to relaunch DevLauncherExpoDevLauncherBridgeDelegateHandlerto handle opening apps fromExpoDevLauncherReactDelegateHandleropenDevMenuFromReactNativeto ensure the DevMenu is closed before opening the react-native dev menuTest Plan
Run
fabric-testerandbare-expoon iOSScreen.Recording.2023-06-13.at.14.09.29.mov
Screen.Recording.2023-06-12.at.14.43.03.mov
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).