[core] fix incorrect conversion of valid url #23331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanjhughes
changed the title
expo-bot
added
bot: passed checks
tsapeta
reviewed
Jul 6, 2023
|
Yes, I think it's fine to remove it. The encoding get's handled correctly so we don't need that one |
tsapeta
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #23282
Some unusual but valid URLs will fail to be created with
URL(string:)example: https://matrix.to/#/#sh.itjust.works:matrix.org
When this happens the URL is assumed to be a file which then crashes the app once it's passed to the browser
How
Create the URL with URLComponents which ensures it is RFC 3986 compliant.
Test Plan
Tested with multiple variations of URL and the one causing the issue. All work correctly.