fix(router): fix navigation with nested <Slot /> layouts #24598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-10211 Nested _layout.js with Slot breaking dynamic routing in expo-router 2.0.7
This issue was automatically imported from GitHub: #24576Issue accepted by brentSummary:
|
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
This was referenced Sep 25, 2023
EvanBacon
approved these changes
Sep 25, 2023
EvanBacon
added a commit
that referenced
this pull request
Dec 15, 2023
# Why `router.push()` should always most history forwards. However we are currently using the `NAVIGATE` action which may move history backwards if the screen is in history and the closest navigator is a Stack. Adds `router.navigate` for when users wish to opt out of this behaviour. Fix: expo/router#758 Fix: expo/router#741 Keeping this in draft until #24598 is merged # How This changes `router.push()` to a PUSH action if the lowest nested navigator is a stack and shared between the old & new routes. Otherwise it defaults back to NAVIGATE. # Test Plan Included test case # Checklist - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Evan Bacon <bacon@expo.io> Co-authored-by: Aman Mittal <amandeepmittal@live.com> Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
…4600) # Why `router.push()` should always most history forwards. However we are currently using the `NAVIGATE` action which may move history backwards if the screen is in history and the closest navigator is a Stack. Adds `router.navigate` for when users wish to opt out of this behaviour. Fix: expo/router#758 Fix: expo/router#741 Keeping this in draft until expo#24598 is merged # How This changes `router.push()` to a PUSH action if the lowest nested navigator is a stack and shared between the old & new routes. Otherwise it defaults back to NAVIGATE. # Test Plan Included test case # Checklist - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Evan Bacon <bacon@expo.io> Co-authored-by: Aman Mittal <amandeepmittal@live.com> Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes: #24576
How
We should be using
targetinstead ofsourcefor our navigation.Test Plan
Added new test. Verified with reproduction from #24596
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).