Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport ENG-10211 #888

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: backport ENG-10211 #888

merged 1 commit into from
Sep 25, 2023

Conversation

marklawlor
Copy link
Contributor

@marklawlor marklawlor commented Sep 25, 2023

Motivation

Backport expo/expo#24598

Execution

Test Plan

@linear
Copy link

linear bot commented Sep 25, 2023

ENG-10211 Nested _layout.js with Slot breaking dynamic routing in expo-router 2.0.7

This issue was automatically imported from GitHub: expo/expo#24576

Issue accepted by brent


Summary:

  • The user has encountered an issue with expo-router after updating it from version 2.0.5 to 2.0.7. This was originally done to fix a navigating issue with nested slots.
  • Navigating to dynamic routes is broken when using nested slots.
  • The user's test app contains a _layout.js file with Slot at the root and two child routes, each with its own _layout.js file.
  • They have tested two ways of dynamic routing, one involving a folder name that contains the dynamic ID and one involving a filename that contains the dynamic ID.
  • Removing one of the child _layout.js files fixes routing to the respective dynamic route.

@marklawlor marklawlor merged commit 530821d into main Sep 25, 2023
6 checks passed
@marklawlor marklawlor deleted the marklawlor/ENG-10211 branch September 25, 2023 21:08
@pang0018
Copy link

@marklawlor now that this is merged, how soon can we expect the next release?

@pang0018
Copy link

@marklawlor now that this is merged, how soon can we expect the next release?

Bump ^, or maybe @EvanBacon can share the cadence on releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants