fix(expo-modules-autolinking): resolve packages from expo package context
#25817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
force-pushed
the
@bycedric/autolinking/fix-isolated-module-issues
branch
2 times, most recently
from
6208c04
to
18360a3
Compare
This was referenced Dec 8, 2023
byCedric
force-pushed
the
@bycedric/autolinking/fix-isolated-module-issues
branch
from
18360a3
to
524dacb
Compare
tsapeta
approved these changes
Dec 9, 2023
…project_integrator.rb` Co-authored-by: franksmule <ollie@lunak.uk>
Co-authored-by: franksmule <ollie@lunak.uk>
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
byCedric
force-pushed
the
@bycedric/autolinking/fix-isolated-module-issues
branch
from
524dacb
to
5a154a4
Compare
github-actions
bot
added
bot: fingerprint changed
and removed
bot: fingerprint compatible
labels
This comment was marked as off-topic.
This comment was marked as off-topic.
byCedric
deleted the
@bycedric/autolinking/fix-isolated-module-issues
branch
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
…ontext (expo#25817) # Why This is the same as expo#25717, but with additional changes for CI. # How - Added `{ paths: require.resolve('expo/package.json') }` to the generated project integrator script - Updated `Bundle React Native code and images` buildphase to resolve `@expo/cli` from `expo` Once everything is running correctly, I'll make some tweaks to avoid the double-resolves we are doing in most places. We can change things like: ```js require(require.resolve('expo-modules-autolinking', { paths: [require.resolve('expo/package.json')] })) ``` With ```js require('expo/autolinking') ``` This is because `expo` is a direct project dependency, and thus always resolve-able from the project root (or `<projectRoot>/ios/Pods` directories). But let's do this _after_ it works. # Test Plan TBD # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: franksmule <ollie@lunak.uk> Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This is the same as #25717, but with additional changes for CI.
How
{ paths: require.resolve('expo/package.json') }to the generated project integrator scriptBundle React Native code and imagesbuildphase to resolve@expo/clifromexpoOnce everything is running correctly, I'll make some tweaks to avoid the double-resolves we are doing in most places. We can change things like:
With
This is because
expois a direct project dependency, and thus always resolve-able from the project root (or<projectRoot>/ios/Podsdirectories). But let's do this after it works.Test Plan
TBD
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).