Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade react-native 0.73.2 #26308

Merged
merged 8 commits into from Jan 8, 2024

Conversation

gabrieldonadel
Copy link
Member

Why

Follow up #25998 for react-native 0.73 upgrade
Closes ENG-11013

How

  • update package versions
    • react-native 0.73.1 -> 0.73.2

Test Plan

  • bare-expo ios / android
  • Expo Go
  • fabric ios / android
  • ci passed

Checklist

Copy link

linear bot commented Jan 8, 2024

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 8, 2024
@brentvatne
Copy link
Member

let's cherry-pick this to main after as well!

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 8, 2024
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/upgrade-react-native-0-73-2 branch from b73e441 to 9ca4668 Compare January 8, 2024 21:10
@gabrieldonadel
Copy link
Member Author

Updates e2e on android failed to build com.wix:detox because https://oss.sonatype.org/content/repositories/snapshots/com/wix/detox/maven-metadata.xml is not available (maybe another outage?)

"Check Template Bare Minimum Diffs" is just flaky as hell, I rerun this command multiple times and now everything seems to be correct

@gabrieldonadel gabrieldonadel merged commit e60099e into sdk-50 Jan 8, 2024
24 of 26 checks passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/upgrade-react-native-0-73-2 branch January 8, 2024 22:19
@brentvatne
Copy link
Member

cc @keith-kurak - maybe worth chatting with @gabrieldonadel about the bare minimum template diffs command to see what we can do to improve it

gabrieldonadel added a commit that referenced this pull request Jan 8, 2024
Follow up #25998 for react-native 0.73
upgrade
Closes ENG-11013

- update package versions
  - `react-native 0.73.1 -> 0.73.2`

- bare-expo ios / android
- Expo Go
- fabric ios / android
- ci passed

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
gabrieldonadel added a commit that referenced this pull request Jan 8, 2024
Follow up #25998 for react-native 0.73
upgrade
Closes ENG-11013

- update package versions
  - `react-native 0.73.1 -> 0.73.2`

- bare-expo ios / android
- Expo Go
- fabric ios / android
- ci passed

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
gabrieldonadel added a commit that referenced this pull request Jan 9, 2024
Follow up #25998 for react-native 0.73
upgrade
Closes ENG-11013

- update package versions
  - `react-native 0.73.1 -> 0.73.2`

- bare-expo ios / android
- Expo Go
- fabric ios / android
- ci passed

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
gabrieldonadel added a commit that referenced this pull request Jan 9, 2024
Follow up #25998 for react-native 0.73
upgrade
Closes ENG-11013

- update package versions
  - `react-native 0.73.1 -> 0.73.2`

- bare-expo ios / android
- Expo Go
- fabric ios / android
- ci passed

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
gabrieldonadel added a commit that referenced this pull request Jan 9, 2024
# Why

Backport #26308 to main

# How

`git cherry-pick e60099e `

# Test Plan

- bare-expo ios / android
- Expo Go
- fabric ios / android
- ci passed

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Jan 10, 2024
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
# Why

Backport expo#26308 to main

# How

`git cherry-pick e60099e `

# Test Plan

- bare-expo ios / android
- Expo Go
- fabric ios / android
- ci passed

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
@gabrieldonadel gabrieldonadel mentioned this pull request Jan 29, 2024
3 tasks
gabrieldonadel added a commit that referenced this pull request Feb 6, 2024
# Why

Follow up #26308 for react-native 0.73
upgrade

# How

- update package versions
  - `react-native 0.73.2 -> 0.73.4`   
  
# Test Plan

- bare-expo ios / android
- Expo Go
- fabric ios / android
- ci passed
 

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
gabrieldonadel added a commit that referenced this pull request Feb 6, 2024
Follow up #26308 for react-native 0.73
upgrade

- update package versions
  - `react-native 0.73.2 -> 0.73.4`

- bare-expo ios / android
- Expo Go
- fabric ios / android
- ci passed

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
gabrieldonadel added a commit that referenced this pull request Feb 6, 2024
Follow up #26308 for react-native 0.73
upgrade

- update package versions
  - `react-native 0.73.2 -> 0.73.4`

- bare-expo ios / android
- Expo Go
- fabric ios / android
- ci passed

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
gabrieldonadel added a commit that referenced this pull request Feb 8, 2024
Follow up #26308 for react-native 0.73
upgrade

- update package versions
  - `react-native 0.73.2 -> 0.73.4`

- bare-expo ios / android
- Expo Go
- fabric ios / android
- ci passed

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
gabrieldonadel added a commit that referenced this pull request Feb 8, 2024
Follow up #26308 for react-native 0.73
upgrade

- update package versions
  - `react-native 0.73.2 -> 0.73.4`

- bare-expo ios / android
- Expo Go
- fabric ios / android
- ci passed

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants