upgrade react-native 0.73.4 #26774
Merged
upgrade react-native 0.73.4 #26774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
requested review from
ide,
tsapeta,
brentvatne,
lukmccall,
douglowder,
Simek and
amandeepmittal
as code owners
expo-bot
added
bot: suggestions
gabrieldonadel
force-pushed
the
@gabrieldonadel/upgrade-react-native-0-73-3
branch
2 times, most recently
from
52930c4
to
10a2d22
Compare
1 task
tsapeta
approved these changes
Jan 30, 2024
lukmccall
approved these changes
Jan 30, 2024
gabrieldonadel
force-pushed
the
@gabrieldonadel/upgrade-react-native-0-73-3
branch
from
10a2d22
to
24bb584
Compare
|
I'm holding on merging this for now given this new version is throwing a warning as soon as the app starts and will probably cause some confusion for people. |
douglowder
approved these changes
Jan 31, 2024
|
Expo 50.0.5 version has been released, but react native version is still 0.73.2. Do you have any information about when it will be published? |
|
@hasanaktas - we intentionally did not land this yet because we don't believe it's good to upgrade to 0.73.3. as @gabrieldonadel pointed out, 0.73.3 includes a regression that results in a warning on startup on every ios app. it will be fixed by facebook/react-native#42734 and then when that is published 0.73.4, we will update the recommended version. this is a work in progress. |
|
0.73.4 out now fyi :) |
gabrieldonadel
changed the title
gabrieldonadel
force-pushed
the
@gabrieldonadel/upgrade-react-native-0-73-3
branch
from
5ae7b9e
to
73ad584
Compare
tsapeta
approved these changes
Feb 6, 2024
gabrieldonadel
force-pushed
the
@gabrieldonadel/upgrade-react-native-0-73-3
branch
from
73ad584
to
1ad265b
Compare
brentvatne
approved these changes
Feb 6, 2024
gabrieldonadel
deleted the
@gabrieldonadel/upgrade-react-native-0-73-3
branch
gabrieldonadel
added a commit
that referenced
this pull request
Feb 6, 2024
Follow up #26308 for react-native 0.73 upgrade - update package versions - `react-native 0.73.2 -> 0.73.4` - bare-expo ios / android - Expo Go - fabric ios / android - ci passed <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
3 tasks
gabrieldonadel
added a commit
that referenced
this pull request
Feb 6, 2024
Follow up #26308 for react-native 0.73 upgrade - update package versions - `react-native 0.73.2 -> 0.73.4` - bare-expo ios / android - Expo Go - fabric ios / android - ci passed <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
gabrieldonadel
added a commit
that referenced
this pull request
Feb 8, 2024
Follow up #26308 for react-native 0.73 upgrade - update package versions - `react-native 0.73.2 -> 0.73.4` - bare-expo ios / android - Expo Go - fabric ios / android - ci passed <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
gabrieldonadel
added a commit
that referenced
this pull request
Feb 8, 2024
Follow up #26308 for react-native 0.73 upgrade - update package versions - `react-native 0.73.2 -> 0.73.4` - bare-expo ios / android - Expo Go - fabric ios / android - ci passed <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
gabrieldonadel
added a commit
that referenced
this pull request
Feb 8, 2024
# Why Backport #26774 to main # How `git cherry-pick 067e7b8 ` # Test Plan - bare-expo ios / android - Expo Go - fabric ios / android - ci passed # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
3 tasks
gabrieldonadel
added a commit
that referenced
this pull request
Mar 8, 2024
# Why Follow up #26774 for react-native 0.73 upgrade # How - update package versions - `react-native 0.73.4 -> 0.73.5` # Test Plan - bare-expo ios / android - Expo Go - fabric ios / android - ci passed # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Follow up #26308 for react-native 0.73 upgrade
How
react-native 0.73.2 -> 0.73.4Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).