[dev-launcher] Fix launcher bridge not filtering modules #26332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudo
approved these changes
Jan 9, 2024
expo-bot
added
bot: passed checks
gabrieldonadel
added a commit
that referenced
this pull request
Jan 9, 2024
# Why Closes ENG-11046 Closes #26298 # How Overwrite `EXDevLauncherBridgeDelegate` `createBridgeWithDelegate` method to ensure we use `EXDevLauncherRCTBridge` instead of the standard `RCTBridge` for the launcher, preventing native modules like RealmJS from getting wrongly initialized. # Test Plan Temporarily added `realm` to bare-expo and fabric-tester # Checklist - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why Closes ENG-11046 Closes expo#26298 # How Overwrite `EXDevLauncherBridgeDelegate` `createBridgeWithDelegate` method to ensure we use `EXDevLauncherRCTBridge` instead of the standard `RCTBridge` for the launcher, preventing native modules like RealmJS from getting wrongly initialized. # Test Plan Temporarily added `realm` to bare-expo and fabric-tester # Checklist - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-11046
Closes #26298
How
Overwrite
EXDevLauncherBridgeDelegatecreateBridgeWithDelegatemethod to ensure we useEXDevLauncherRCTBridgeinstead of the standardRCTBridgefor the launcher, preventing native modules like RealmJS from getting wrongly initialized.Test Plan
Temporarily added
realmto bare-expo and fabric-testerChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).