Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-launcher] Fix launcher bridge not filtering modules #26332

Merged
merged 2 commits into from
Jan 9, 2024
Merged

[dev-launcher] Fix launcher bridge not filtering modules #26332

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e037728
[dev-launcher] Fix launcher bridge not filtering modules
gabrieldonadel Jan 9, 2024
52663e3
Add changelog entry
gabrieldonadel Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/expo-dev-launcher/ios/EXDevLauncherBridgeDelegate.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#import <EXDevLauncher/EXDevLauncherBridgeDelegate.h>
#import <EXDevLauncher/EXDevLauncherController.h>
#import <EXDevLauncher/EXDevLauncherRCTBridge.h>

#import <React/RCTBundleURLProvider.h>
#if __has_include(<React_RCTAppDelegate/RCTAppSetupUtils.h>)
Expand All @@ -21,6 +22,10 @@ - (NSURL *)sourceURLForBridge:(RCTBridge *)bridge {
return [[EXDevLauncherController sharedInstance] sourceURLForBridge:bridge];
}

- (RCTBridge *)createBridgeWithDelegate:(id<RCTBridgeDelegate>)delegate launchOptions:(NSDictionary *)launchOptions {
return [[EXDevLauncherRCTBridge alloc] initWithDelegate:delegate launchOptions:launchOptions];
}

- (RCTRootView *)createRootViewWithModuleName:(NSString *)moduleName launchOptions:(NSDictionary * _Nullable)launchOptions application:(UIApplication *)application{
BOOL enableTM = NO;
#if RCT_NEW_ARCH_ENABLED
Expand Down
2 changes: 1 addition & 1 deletion packages/expo-dev-launcher/ios/ReactNative/EXDevLauncherRCTBridge.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ - (RCTDevMenu *)devMenu
@"ExpoBridgeModule",
@"EXNativeModulesProxy",
@"ViewManagerAdapter_",
@"ExpoModulesCore"
@"ExpoModulesCore",
@"EXReactNativeEventEmitter"
];
NSArray<Class> *filteredModuleList = [modules filteredArrayUsingPredicate:[NSPredicate predicateWithBlock:^BOOL(id _Nullable clazz, NSDictionary<NSString *,id> * _Nullable bindings) {
Expand Down