Bump puppeteer to 22.4.1, jest-puppeteer to 10.0.1 #27698
Merged
+397
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
requested review from
alanjhughes,
brentvatne and
tsapeta
and removed request for
Simek and
amandeepmittal
alanjhughes
approved these changes
Mar 15, 2024
tsapeta
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Tests are failing to install node modules on the sdk-50 branch because puppeteer never finishes building.
e.g. https://github.com/expo/expo/actions/runs/8281262111/job/22679366958
It seems that there is some issue with the server not closing the connection for the old download url after download is complete. Puppeteer changed endpoints in puppeteer/puppeteer#11923, which means that versions puppeteer<22.1.0 are using the old URL. (Full details here puppeteer/puppeteer#12094)
How
Test Plan
CI should. be green
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).