Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add privacy labels #27868

Closed
wants to merge 4 commits into from
Closed

[iOS] Add privacy labels #27868

wants to merge 4 commits into from

Conversation

aleqsio
Copy link
Contributor

@aleqsio aleqsio commented Mar 26, 2024

We need to decide if we should declare these data types as linked, otherwise ready to merge.

Why

We may want to add privacy labels to common data we collect in our SDK packages.

Related to:
#27796
linear.app/expo/issue/ENG-11731/investigate-ios-privacy-manifest-requirements

How

Added manually to specific packages based on my understanding of the policies.

Test Plan

Checked that the report for bare-expo contains inserted data:
image

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 26, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Mar 26, 2024

The Pull Request introduced fingerprint changes against the base commit: b8af3fa

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-contacts/ios",
    "reasons": [
      "expoAutolinkingIos"
    ],
    "hash": "0b74fa6476b01692918ae2fd579c0b33a8af2805"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-document-picker/ios",
    "reasons": [
      "expoAutolinkingIos"
    ],
    "hash": "08ca4a4ff16fa06d88314ddd59648e5ac0ee470d"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-image-picker/ios",
    "reasons": [
      "expoAutolinkingIos"
    ],
    "hash": "63143c7e840df84e99fb08645841edc190aef61b"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-location/ios",
    "reasons": [
      "expoAutolinkingIos"
    ],
    "hash": "ef3c7675f1c7f12428fb7e9a41cf91358cc20aa0"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-maps/ios",
    "reasons": [
      "expoAutolinkingIos"
    ],
    "hash": "c5870eb046e7587e98faa86756cb15602a940f19"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-media-library/ios",
    "reasons": [
      "expoAutolinkingIos"
    ],
    "hash": "d979b00c93278caf67721518befdae42d38d04d4"
  },
  {
    "type": "dir",
    "filePath": "ios",
    "reasons": [
      "bareNativeDir"
    ],
    "hash": "0f548a817035685e3e99ed7041fd8914851003a6"
  }
]

Generated by PR labeler 🤖

@aleqsio aleqsio changed the title Add privacy labels [iOS] Add privacy labels Mar 26, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 26, 2024
@aleqsio aleqsio marked this pull request as ready for review March 26, 2024 15:33
@aleqsio
Copy link
Contributor Author

aleqsio commented Mar 27, 2024

Closing for now – we're assuming that since we're not collecting that data ourselves, this is not accurate.

@aleqsio aleqsio closed this Mar 27, 2024
@tsapeta tsapeta deleted the @aleqsio/add-privacy-labels branch March 27, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants