-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Add privacy labels #27868
Closed
Closed
[iOS] Add privacy labels #27868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleqsio
force-pushed
the
@aleqsio/add-privacy-labels
branch
from
March 26, 2024 12:59
8dde7ac
to
7373184
Compare
The Pull Request introduced fingerprint changes against the base commit: b8af3fa Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-contacts/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "0b74fa6476b01692918ae2fd579c0b33a8af2805"
},
{
"type": "dir",
"filePath": "../../packages/expo-document-picker/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "08ca4a4ff16fa06d88314ddd59648e5ac0ee470d"
},
{
"type": "dir",
"filePath": "../../packages/expo-image-picker/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "63143c7e840df84e99fb08645841edc190aef61b"
},
{
"type": "dir",
"filePath": "../../packages/expo-location/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "ef3c7675f1c7f12428fb7e9a41cf91358cc20aa0"
},
{
"type": "dir",
"filePath": "../../packages/expo-maps/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "c5870eb046e7587e98faa86756cb15602a940f19"
},
{
"type": "dir",
"filePath": "../../packages/expo-media-library/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "d979b00c93278caf67721518befdae42d38d04d4"
},
{
"type": "dir",
"filePath": "ios",
"reasons": [
"bareNativeDir"
],
"hash": "0f548a817035685e3e99ed7041fd8914851003a6"
}
] Generated by PR labeler 🤖 |
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Mar 26, 2024
aleqsio
requested review from
tsapeta,
lukmccall,
alanjhughes,
byCedric,
brentvatne,
Kudo,
ide and
EvanBacon
as code owners
March 26, 2024 15:33
alanjhughes
approved these changes
Mar 26, 2024
lukmccall
approved these changes
Mar 27, 2024
tsapeta
approved these changes
Mar 27, 2024
Closing for now – we're assuming that since we're not collecting that data ourselves, this is not accurate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to decide if we should declare these data types as
linked
, otherwise ready to merge.Why
We may want to add privacy labels to common data we collect in our SDK packages.
Related to:
#27796
linear.app/expo/issue/ENG-11731/investigate-ios-privacy-manifest-requirements
How
Added manually to specific packages based on my understanding of the policies.
Test Plan
Checked that the report for bare-expo contains inserted data:
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).