Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-preset-expo): Fix replacement of __DEV__ in export statement. #28786

Merged
merged 2 commits into from
May 13, 2024

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented May 13, 2024

Why

Fixes a regression that we temporarily fixed in SDK 50. https://exponent-internal.slack.com/archives/C5ERY0TAR/p1715558585127549
Specifically fixes support for syntax used in @apollo/client.
fix #28785

Test Plan

  • Added tests that could reproduce the syntax issue from before.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 13, 2024
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 13, 2024
@EvanBacon EvanBacon merged commit d83f794 into main May 13, 2024
19 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/babel-preset-expo/fix-dev-replacement branch May 13, 2024 16:33
@brentvatne brentvatne added the published Changes from the PR have been published to npm label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK 51][expo-web] @apollo-client fails during expo export with metro for web
4 participants