Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-updates][android] Upgrade dependencies and remove unused ones #29060

Merged
merged 1 commit into from
May 24, 2024

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented May 22, 2024

Why

This removes the following dependencies:

implementation("javax.portlet:portlet-api:3.0.1")
implementation("javax.servlet:javax.servlet-api:4.0.1")

These were added in #24971 to satisfy them no longer being provided in react native, and failing to resolve during release builds if not added.

They are used by apache commons fileupload, which provides a lot of utilities for doing servlet and portlet stuff, which we don't need.

What we do need is a multipart parser (which okhttp now provides) and a parameter parser for parsing content-disposition.

Also some dependencies can be upgraded.

Test Plan

Wait for tests.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 22, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented May 22, 2024

The Pull Request introduced fingerprint changes against the base commit: 79fd5fa

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-updates/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "d5fff87fc71605c6ac7489f572a79b5d46461a40"
  }
]

Generated by PR labeler 🤖

@wschurman wschurman force-pushed the @wschurman/change-expo-updates-to-ksp-2 branch 7 times, most recently from f6204e1 to 1e41650 Compare May 23, 2024 00:01
@wschurman wschurman force-pushed the @wschurman/change-expo-updates-to-ksp branch from d2d58f6 to 6d1a4aa Compare May 23, 2024 00:15
@wschurman wschurman force-pushed the @wschurman/change-expo-updates-to-ksp-2 branch from 1e41650 to a77111a Compare May 23, 2024 17:11
@expo expo deleted a comment from socket-security bot May 23, 2024
@wschurman wschurman force-pushed the @wschurman/change-expo-updates-to-ksp-2 branch from a77111a to 609efac Compare May 23, 2024 19:28
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@react-navigation/bottom-tabs@6.4.3 None +3 353 kB satya164
npm/@react-navigation/native@6.0.16 environment 0 416 kB satya164
npm/dedent@0.7.0 None 0 4.85 kB dmnd
npm/expo-2d-context@0.0.4 None 0 2.34 MB tsapeta
npm/expo-apple-authentication@6.4.1 None 0 108 kB brentvatne
npm/expo-asset@8.14.0 None +4 546 kB wschurman
npm/expo-audio@0.1.0 None 0 12.1 kB brentvatne
npm/expo-auth-session@5.5.2 network 0 394 kB brentvatne
npm/expo-av@14.0.5 None 0 890 kB brentvatne
npm/expo-background-fetch@12.0.1 None 0 52 kB brentvatne
npm/expo-barcode-scanner@13.0.1 None +1 159 kB brentvatne
npm/expo-battery@8.0.1 None 0 84.1 kB brentvatne
npm/expo-brightness@12.0.1 None 0 61.3 kB brentvatne
npm/expo-calendar@13.0.5 None 0 291 kB brentvatne
npm/expo-cellular@6.0.2 None 0 81.1 kB brentvatne
npm/expo-checkbox@3.0.0 None 0 48 kB brentvatne
npm/expo-clipboard@6.0.3 None 0 182 kB brentvatne
npm/expo-constants@15.3.0 Transitive: environment, filesystem, unsafe +14 2.66 MB wschurman
npm/expo-contacts@13.0.3 None 0 269 kB brentvatne
npm/expo-crypto@13.0.2 None 0 71.2 kB brentvatne
npm/expo-dev-client@4.0.14 Transitive: eval, filesystem, unsafe +9 14.3 MB brentvatne
npm/expo-device@6.0.2 None 0 115 kB brentvatne
npm/expo-document-picker@12.0.1 None 0 62.1 kB brentvatne
npm/expo-face-detector@12.7.1 None 0 100 kB brentvatne
npm/expo-file-system@17.0.1 None 0 303 kB brentvatne
npm/expo-gl@14.0.2 None 0 610 kB brentvatne
npm/expo-haptics@13.0.1 None 0 36.1 kB brentvatne
npm/expo-image-manipulator@12.0.5 None 0 127 kB brentvatne
npm/expo-image-picker@15.0.5 None 0 273 kB brentvatne
npm/expo-insights@0.7.0 None +1 23.9 kB brentvatne
npm/expo-intent-launcher@11.0.1 None 0 55.1 kB brentvatne
npm/expo-linking@6.3.1 None 0 110 kB brentvatne
npm/expo-local-authentication@14.0.1 None 0 78.3 kB brentvatne
npm/expo-localization@15.0.3 None 0 133 kB brentvatne
npm/expo-location@17.0.1 None 0 353 kB brentvatne
npm/expo-mail-composer@13.0.1 None 0 40.5 kB brentvatne
npm/expo-maps@0.4.0 None 0 479 kB wschurman
npm/expo-media-library@16.0.3 None 0 277 kB brentvatne
npm/expo-module-scripts@3.5.1 Transitive: environment, filesystem, shell, unsafe +27 16.5 MB brentvatne
npm/expo-modules-test-core@0.18.0 Transitive: environment, filesystem +8 5.26 MB brentvatne
npm/expo-navigation-bar@3.0.4 None 0 89.8 kB brentvatne
npm/expo-network-addons@0.6.0 None 0 11.3 kB brentvatne
npm/expo-network@6.0.1 None 0 41.9 kB brentvatne
npm/expo-notifications@0.28.3 network Transitive: filesystem +10 1.59 MB brentvatne
npm/expo-print@13.0.1 None 0 80.6 kB brentvatne
npm/expo-processing@2.3.7 None 0 5.37 kB brentvatne
npm/expo-router@3.5.14 environment, network Transitive: eval +4 2.84 MB brentvatne
npm/expo-screen-capture@6.0.1 None 0 50.7 kB brentvatne
npm/expo-screen-orientation@7.0.5 None 0 146 kB brentvatne
npm/expo-secure-store@13.0.1 None 0 102 kB brentvatne
npm/expo-sensors@13.0.7 None 0 225 kB brentvatne
npm/expo-sharing@12.0.1 None 0 29.7 kB brentvatne
npm/expo-sms@12.0.1 None 0 40.2 kB brentvatne
npm/expo-speech@12.0.2 None 0 70.2 kB brentvatne
npm/expo-splash-screen@0.27.4 Transitive: environment, filesystem, network, unsafe +17 2.24 MB brentvatne
npm/expo-sqlite@14.0.3 None 0 9.18 MB brentvatne
npm/expo-standard-web-crypto@1.8.1 None 0 15.3 kB brentvatne
npm/expo-status-bar@1.12.1 None 0 43.7 kB brentvatne
npm/expo-store-review@7.0.2 None 0 29.9 kB brentvatne
npm/expo-symbols@0.1.4 None 0 39 kB brentvatne
npm/expo-system-ui@3.0.4 None 0 44.7 kB brentvatne
npm/expo-task-manager@11.8.1 None +1 164 kB brentvatne
npm/expo-tracking-transparency@4.0.2 None 0 45.2 kB brentvatne
npm/expo-updates@0.25.14 Transitive: environment, filesystem, unsafe +9 3.93 MB brentvatne
npm/expo-video-thumbnails@8.0.0 None 0 28.3 kB brentvatne
npm/expo-video@1.1.9 None 0 237 kB brentvatne
npm/expo-web-browser@13.0.3 None 0 186 kB brentvatne
npm/immutable@4.3.6 None 0 682 kB leebyron
npm/path-to-regexp@1.8.0 None +1 34.5 kB blakeembrey
npm/react-dom@18.2.0 environment +1 4.6 MB gnoff
npm/react-native-paper@4.12.8 None +3 3.59 MB lukewalczak
npm/react-native-reanimated@3.10.1 environment, eval 0 3.83 MB piaskowyk
npm/react-native-svg@15.2.0 network 0 2.84 MB wolewicki
npm/react-native@0.74.1 environment, network Transitive: eval, filesystem, shell, unsafe +103 101 MB react-native-bot
npm/test-suite@1.0.0 None 0 744 B afaq
npm/three@0.137.5 None 0 32.8 MB mrdoob

🚮 Removed packages: npm/@eslint-community/eslint-utils@4.4.0, npm/@eslint-community/regexpp@4.10.0, npm/@jridgewell/sourcemap-codec@1.4.15, npm/@jridgewell/trace-mapping@0.3.25, npm/@types/json-schema@7.0.15, npm/cookie@0.6.0, npm/debug@4.3.4, npm/is-extglob@2.1.1, npm/is-glob@4.0.3, npm/jest-snapshot-prettier@2.8.8, npm/ms@2.1.2, npm/nanoid@3.3.7, npm/typescript@5.4.5

View full report↗︎

@wschurman wschurman marked this pull request as ready for review May 23, 2024 20:01
@wschurman wschurman requested a review from Kudo May 23, 2024 20:02
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code generally looks good but unfortunately there're failures for androidTest on expo-modules-core and i cannot review whether the updates' androidTest are passed or not.

don't want to block the pr much. if tests are passed for you locally and you could just merge this.

@wschurman wschurman force-pushed the @wschurman/change-expo-updates-to-ksp branch from 6d1a4aa to 53a7111 Compare May 24, 2024 16:32
Base automatically changed from @wschurman/change-expo-updates-to-ksp to main May 24, 2024 16:32
@wschurman wschurman force-pushed the @wschurman/change-expo-updates-to-ksp-2 branch from 609efac to 4590c93 Compare May 24, 2024 16:36
@wschurman wschurman merged commit 9817291 into main May 24, 2024
16 of 19 checks passed
@wschurman wschurman deleted the @wschurman/change-expo-updates-to-ksp-2 branch May 24, 2024 16:36
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants