-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo-updates][android] Upgrade dependencies and remove unused ones #29060
Conversation
The Pull Request introduced fingerprint changes against the base commit: 79fd5fa Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-updates/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "d5fff87fc71605c6ac7489f572a79b5d46461a40"
}
] Generated by PR labeler 🤖 |
f6204e1
to
1e41650
Compare
d2d58f6
to
6d1a4aa
Compare
1e41650
to
a77111a
Compare
a77111a
to
609efac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code generally looks good but unfortunately there're failures for androidTest on expo-modules-core and i cannot review whether the updates' androidTest are passed or not.
don't want to block the pr much. if tests are passed for you locally and you could just merge this.
packages/expo-updates/android/src/main/java/expo/modules/updates/UpdatesUtils.kt
Outdated
Show resolved
Hide resolved
6d1a4aa
to
53a7111
Compare
609efac
to
4590c93
Compare
Why
This removes the following dependencies:
These were added in #24971 to satisfy them no longer being provided in react native, and failing to resolve during release builds if not added.
They are used by apache commons fileupload, which provides a lot of utilities for doing servlet and portlet stuff, which we don't need.
What we do need is a multipart parser (which okhttp now provides) and a parameter parser for parsing
content-disposition
.Also some dependencies can be upgraded.
Test Plan
Wait for tests.
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).