[docs] Merge ImageSpotlight and Video to ContentSpotlight
#29641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simek
reviewed
Jun 11, 2024
Simek
reviewed
Jun 13, 2024
Simek
reviewed
Jun 13, 2024
Simek
reviewed
Jun 13, 2024
Simek
approved these changes
Jun 13, 2024
amandeepmittal
deleted the
aman/eng-11611-unify-imagespotlight-and-video-components
branch
3 tasks
amandeepmittal
added a commit
that referenced
this pull request
Jun 16, 2024
…light` (#29787) # Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> Closes ENG-12469 ENG-12468 # How <!-- How did you build this feature or fix this bug and why? --> - Use `ContentSpotlight` to display images and videos in our docs and replace `ImageSpotlight` and `Video` components. - Remove `ImageSpotlight` and `Video` component files. - Update **docs/README.md** > Add videos section's example to use `ContentSpotlight`. - Follow up #29641 # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> Run docs locally and manually check that all images and videos are displayed as usual. Also run `yarn run test` and all tests are passing. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-11611
How
ContentSpotlight) to share props for displaying an image or a video in the Expo docs.ImageSpotlightandVideo.Test Plan
By running docs locally, replacing
ImageSpotlightandVideoreferences withContentSpotlight.Preview of tested changes
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).