Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): upgrade glob@7 to glob@10 #29898

Open
wants to merge 9 commits into
base: @bycedric/config-plugins/upgrade-glob-to-10
Choose a base branch
from

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Jun 20, 2024

Blocked by #29929
Blocked by #29894
Blocked by #29985

Why

How

  • Upgraded glob@7 to glob@10
  • Added tests for glob utilities
  • Added tests for timeout glob in TypeScriptProjectPrerequisite
  • Reimplemented glob utilities
  • Reimplemented timeout glob in TypeScriptProjectPrerequisite
  • Added missing @types/glob to all packages still using glob@7

Test Plan

See if CI and tests passes

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 20, 2024
@byCedric byCedric force-pushed the @bycedric/cli/upgrade-glob-to-10 branch from fd12447 to e32266f Compare June 20, 2024 13:27
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 20, 2024
@byCedric byCedric marked this pull request as ready for review June 20, 2024 14:03
@byCedric
Copy link
Member Author

byCedric commented Jun 20, 2024

Edit: the other glob upgrade PRs have been merged, and I dropped this commit. Let's see what CI can tell us.


Funny how we relied on @types/glob being there through so many implicit ways, causing issues like these when modifying an unrelated package.

image

I just added @types/glob to all packages using glob@7 (in newer versions types are shipped in glob). I'll refactor the other packages to upgrade them to glob@10 as well.

@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions and removed bot: passed checks ExpoBot has nothing to complain about labels Jun 20, 2024
@ide ide removed their request for review June 20, 2024 18:51
@byCedric byCedric force-pushed the @bycedric/config-plugins/upgrade-glob-to-10 branch from 5468104 to 306d180 Compare June 21, 2024 09:55
@byCedric byCedric force-pushed the @bycedric/config-plugins/upgrade-glob-to-10 branch from 306d180 to 7d6c0a8 Compare June 25, 2024 07:48
@byCedric byCedric requested a review from Kudo as a code owner June 25, 2024 07:48
@byCedric byCedric force-pushed the @bycedric/cli/upgrade-glob-to-10 branch from 63aa44d to 0a392e6 Compare June 25, 2024 07:53
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 25, 2024
@byCedric byCedric force-pushed the @bycedric/config-plugins/upgrade-glob-to-10 branch from 7d6c0a8 to 9de9789 Compare June 29, 2024 21:44
@byCedric byCedric force-pushed the @bycedric/cli/upgrade-glob-to-10 branch from 0a392e6 to de8ebbf Compare June 29, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants